runtime-next: remove hardcoded materialization ser_policy fallback#3140
Draft
dgreer-dev wants to merge 1 commit into
Draft
runtime-next: remove hardcoded materialization ser_policy fallback#3140dgreer-dev wants to merge 1 commit into
dgreer-dev wants to merge 1 commit into
Conversation
The runtime has sniffed endpoint config bytes for well-known connector image names and applied a hardcoded truncation policy on match, because those connectors couldn't yet negotiate one. Serialization policies are now negotiated via the connector protocol: connectors return ser_policy in their Validated response and it's baked into the built binding spec, which build_binding already prefers. All six formerly-hardcoded connectors now return ser_policy (redshift, azure-fabric-warehouse, and sqlite as of estuary/connectors#4787), and the 20-day periodic touch publication cycle refreshes every enabled task's built spec, so the fallback is dead weight. Bindings without a policy now get SerPolicy::noop(). This resolves the TODO(johnny) hack comment and the TODO(whb) removal condition. The V1 runtime keeps its copy of the hack; it's deprecated and not worth touching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the last vestiges of the ser_policy defaults. All but three materializations already have the correct behavior, and a PR has been raised.
Marking this as a draft because we shouldn't merge until that PR has been deployed and all tasks using those connectors have been republished.