redis: log recovery when a connection succeeds after a prior dial error - #1205
Merged
collin-lee merged 1 commit intoAug 5, 2026
Merged
Conversation
Operators currently only see repeated dial-error logs and have no explicit signal when the pool starts succeeding again. Track whether the last dial attempt failed and log once when a subsequent connection succeeds. Signed-off-by: kiran malsetty <kiran.malsetty@outsystems.com>
OS-kiranmalsetty
force-pushed
the
redis-conn-error-recovery-log
branch
from
August 5, 2026 15:43
e711bfd to
d4c2dbb
Compare
Contributor
Author
|
@collin-lee, can you please review when you have a chance? |
collin-lee
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atomic.BooltopoolStatsthat tracks whether the most recent Redis dial attempt failed.Test plan
go build ./...go vet ./src/redis/...go test ./test/redis/...