Skip to content

Remove ember-source@6.11.0 patch - #709

Merged
NullVoxPopuli merged 1 commit into
embroider-build:mainfrom
NullVoxPopuli-ai-agent:remove-ember-source-patch
Mar 29, 2026
Merged

Remove ember-source@6.11.0 patch#709
NullVoxPopuli merged 1 commit into
embroider-build:mainfrom
NullVoxPopuli-ai-agent:remove-ember-source-patch

Conversation

@NullVoxPopuli-ai-agent

Copy link
Copy Markdown

Summary

Removes the ember-source@6.11.0 pnpm patch that targeted the legacy AMD bundles (dist/ember.debug.js, dist/ember.prod.js). These bundles are being removed in ember-source v7, making the patch inapplicable going forward. The underlying associateDestroyableChild issue was fixed in ember-source itself.

This also unblocks #708 which couldn't pass CI because the patch fails to apply when the lockfile is regenerated.

Test plan

  • Existing tests pass without the patch

🤖 Generated with Claude Code

The patch targeted the legacy AMD bundles (dist/ember.debug.js,
dist/ember.prod.js) which are being removed in ember-source v7.
The underlying issue (associateDestroyableChild) was fixed in
ember-source itself.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@NullVoxPopuli
NullVoxPopuli merged commit ea6596e into embroider-build:main Mar 29, 2026
181 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants