MSC4311: invites and knocks should contain the create event by FrenchGithubUser · Pull Request #19722 · element-hq/synapse

FrenchGithubUser · 2026-04-23T15:43:59Z

Part of MSC4311: invites and knocks should contain the create event (stripped state for the client API)

Part of #19414

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Code style is correct (run the linters)

MadLittleMods · 2026-04-23T16:41:04Z

+        config = super().default_config()
+        return config
+
+    def test_create_event_present_in_invite_state(self) -> None:


For reference, it looks like we also have TestMSC4311FullCreateEventOnStrippedState in Complement to cover invite_state. Although that test looks flawed

It looks like that test already passes on develop 🤔 How/why would that be the case?

It looks like this is a combination of MSC1772 but it was only a recommendation. And MSC4311 changes that to a requirement

synapse/synapse/config/api.py

Lines 94 to 95 in 93e0497

# Per MSC1772.

(EventTypes.Create, ""),

And then there was a flawed partial MSC4311 implementation introduced in 0eb7252. I'm reverting that change in #19723

MadLittleMods · 2026-04-23T16:43:27Z

    ) -> Iterable[tuple[str, str | None]]:
        """Get the event types and state keys to include in the prejoin state."""
+        # MSC4311: the create event must always be included in invite/knock state.
+        yield EventTypes.Create, ""


Does this PR also cover including the full m.room.create event PDU in the invite_room_state/knock_room_state on m.room.member events (in unsigned)

This is coming from looking at #19414 and seeing the Server-Server (federation) changes mentioned as well for MSC4311

With further understanding as I review this, my guess is no (which is fine, something for another PR)

indeed, it doesn't cover including the full m.room.create event PDU

MadLittleMods · 2026-04-27T19:05:26Z

Thanks for another step closer to spec compliance @FrenchGithubUser 🦈

…hq#19722) Part of MSC4311: invites and knocks should contain the create event (stripped state for the client API) Part of element-hq#19414

@jason-famedly

Tested on NetBSD 10 amd64 with 2026Q2 environment. # Synapse 1.156.0 (2026-07-07) ## Features - Expose [MSC4354 Sticky Events](matrix-org/matrix-spec-proposals#4354) over [MSC4186 (Simplified) Sliding Sync](matrix-org/matrix-spec-proposals#4186). ([\#19591](element-hq/synapse#19591)) - Stabilize support for sending ephemeral events to application services, as per [MSC2409](matrix-org/matrix-spec-proposals#2409). Contributed by @jason-famedly @ Famedly. ([\#19758](element-hq/synapse#19758)) - Include `allowed_room_ids` in the `/summary` client-server API response for rooms with restricted join rules, as required by Matrix 1.15. Contributed by @FrenchGithubUser @famedly. ([\#19762](element-hq/synapse#19762)) - [MSC4140: Cancellable delayed events](matrix-org/matrix-spec-proposals#4140): Allow authentication on delayed event management endpoints (such as `/restart`) to bypass ratelimits for unauthenticated requests based on the client IP address. ([\#19794](element-hq/synapse#19794)) - Add new metric `synapse_non_deactivated_user_count` which tracks the number of non-deactivated users in the database, split by `app_service`. ([\#19848](element-hq/synapse#19848)) - The `GET /_matrix/client/unstable/org.matrix.msc1763/retention/configuration` endpoint is now provided when retention is enabled and `experimental_features.msc1763_enabled` is enabled, based on [MSC1763](matrix-org/matrix-spec-proposals#1763). ([\#19853](element-hq/synapse#19853)) - Add experimental support for [MSC4491: Invite reasons in room creation](matrix-org/matrix-spec-proposals#4491). ([\#19874](element-hq/synapse#19874)) # Synapse 1.155.0 (2026-06-16) # Synapse 1.154.0 (2026-06-04) ## Features - Add support for [MSC4452: Preview URL capabilities API](matrix-org/matrix-spec-proposals#4452) which exposes a `io.element.msc4452.preview_url` capability. If `experimental_features.msc4452_enabled` is `true`, the `/_matrix/(client/v1/media|media/v3)/preview_url` endpoint now responds with a 403 status code when the capability is disabled. ([\#19715](element-hq/synapse#19715)) # Synapse 1.153.0 (2026-05-19) ## Features - Make ACLs apply to EDUs per [MSC4163](matrix-org/matrix-spec-proposals#4163). ([\#18475](element-hq/synapse#18475)) - Stabilize [MSC3266: Room summary API](matrix-org/matrix-spec-proposals#3266), removing the experimental config flag `msc3266_enabled`. Contributed by @dasha-uwu. ([\#19720](element-hq/synapse#19720)) - Partial [MSC4311](matrix-org/matrix-spec-proposals#4311) implementation: `m.room.create` is now a required part of stripped `invite_state`/`knock_state` . Contributed by @FrenchGithubUser @famedly. ([\#19722](element-hq/synapse#19722)) - Expose `tombstoned` and `replacement_room` in room details on admin API endpoint `GET /_synapse/admin/v1/rooms/<room_id>`. Contributed by Noah Markert. ([\#19737](element-hq/synapse#19737)) # Synapse 1.152.1 (2026-05-07) # Synapse 1.152.0 (2026-04-28) ## Features - Add a ["Listing quarantined media changes" Admin API](https://element-hq.github.io/synapse/latest/admin_api/media_admin_api.html#listing-quarantined-media-changes) for retrieving a paginated record of when media became (un)quarantined. ([\#19558](element-hq/synapse#19558), [\#19677](element-hq/synapse#19677), [\#19694](element-hq/synapse#19694)) - Advertise [MSC4445](matrix-org/matrix-spec-proposals#4445) sync timeline order in `unstable_features`. ([\#19642](element-hq/synapse#19642)) - Report the Rust compiler version used in the Prometheus metrics. Contributed by Noah Markert. ([\#19643](element-hq/synapse#19643)) - Passthrough 'article' and 'profile' OpenGraph metadata on URL preview requests. ([\#19659](element-hq/synapse#19659)) - Add a way to re-sign local events with a new signing key. ([\#19668](element-hq/synapse#19668)) - Support [MSC4450: Identity Provider selection for User-Interactive Authentication with Legacy Single Sign-On](matrix-org/matrix-spec-proposals#4450). ([\#19693](element-hq/synapse#19693)) - Add experimental support for [MSC4242](matrix-org/matrix-spec-proposals#4242): State DAGs. Excludes federation support. ([\#19424](element-hq/synapse#19424)) - Adds [Admin API](https://element-hq.github.io/synapse/latest/usage/administration/admin_api/index.html) endpoints to list, fetch and delete user reports. ([\#19657](element-hq/synapse#19657)) - Reduce database disk space usage by pruning old rows from `device_lists_changes_in_room`. ([\#19473](element-hq/synapse#19473), [\#19709](element-hq/synapse#19709)) # Synapse 1.151.0 (2026-04-07) ## Features - Add stable support for [MSC4284](matrix-org/matrix-spec-proposals#4284) Policy Servers. ([\#19503](element-hq/synapse#19503)) - Update and stabilize support for [MSC2666](matrix-org/matrix-spec-proposals#2666): Get rooms in common with another user. Contributed by @tulir @ Beeper. ([\#19511](element-hq/synapse#19511)) - Updated experimental support for [MSC4388: Secure out-of-band channel for sign in with QR](matrix-org/matrix-spec-proposals#4388). ([\#19573](element-hq/synapse#19573)) - Stabilize `room_version` and `encryption` fields in the space/room `/hierarchy` API (part of [MSC3266](matrix-org/matrix-spec-proposals#3266)). ([\#19576](element-hq/synapse#19576)) - Introduce a [configuration option](https://element-hq.github.io/synapse/latest/usage/configuration/config_documentation.html#matrix_authentication_service) to allow using HTTP/2 over plaintext when Synapse connects to Matrix Authentication Service. ([\#19586](element-hq/synapse#19586)) ## Deprecations and Removals - Remove support for [MSC3852: Expose user agent information on Device](matrix-org/matrix-spec-proposals#3852) as the MSC was closed. ([\#19430](element-hq/synapse#19430)) # Synapse 1.150.0 (2026-03-24) ## Features - Add experimental support for the [MSC4370](matrix-org/matrix-spec-proposals#4370) Federation API `GET /extremities` endpoint. ([\#19314](element-hq/synapse#19314)) - [MSC4140: Cancellable delayed events](matrix-org/matrix-spec-proposals#4140): When persisting a delayed event to the timeline, include its `delay_id` in the event's `unsigned` section in `/sync` responses to the event sender. ([\#19479](element-hq/synapse#19479)) - Expose [MSC4354 Sticky Events](matrix-org/matrix-spec-proposals#4354) over the legacy (v3) /sync API. ([\#19487](element-hq/synapse#19487)) - When Matrix Authentication Service (MAS) integration is enabled, allow MAS to set the user locked status in Synapse. ([\#19554](element-hq/synapse#19554))

MSC4311: invites and knocks should contain the create event

abd9b98

FrenchGithubUser marked this pull request as ready for review April 23, 2026 15:44

FrenchGithubUser requested a review from a team as a code owner April 23, 2026 15:44

MadLittleMods added A-Invite A-Knock labels Apr 23, 2026

MadLittleMods mentioned this pull request Apr 23, 2026

MSC4311: Use full PDU's in stripped state (like invite_room_state) over federation and always include m.room.create event #19723

Open

9 tasks

MadLittleMods reviewed Apr 23, 2026

View reviewed changes

MadLittleMods mentioned this pull request Apr 23, 2026

Support Matrix 1.16 #19414

Open

35 tasks

MadLittleMods reviewed Apr 23, 2026

View reviewed changes

Comment thread changelog.d/19722.feature Outdated

FrenchGithubUser requested a review from MadLittleMods April 24, 2026 09:31

MadLittleMods approved these changes Apr 24, 2026

View reviewed changes

MadLittleMods reviewed Apr 24, 2026

View reviewed changes

Comment thread tests/config/test_api.py Outdated

apply suggestions

b661661

FrenchGithubUser force-pushed the tt/invite-knock-create-event branch from 4488101 to b661661 Compare April 27, 2026 09:19

MadLittleMods merged commit 449b1a4 into element-hq:develop Apr 27, 2026
72 of 75 checks passed

FrenchGithubUser mentioned this pull request May 4, 2026

MSC4311: send full PDUs in invite_room_state/knock_room_state over #19749

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MSC4311: invites and knocks should contain the create event#19722

MSC4311: invites and knocks should contain the create event#19722
MadLittleMods merged 2 commits into
element-hq:developfrom
famedly:tt/invite-knock-create-event

FrenchGithubUser commented Apr 23, 2026 •

edited by MadLittleMods

Loading

Uh oh!

MadLittleMods Apr 23, 2026

Uh oh!

MadLittleMods Apr 23, 2026

Uh oh!

MadLittleMods Apr 23, 2026

Uh oh!

MadLittleMods Apr 23, 2026

Uh oh!

FrenchGithubUser Apr 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MadLittleMods commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

FrenchGithubUser commented Apr 23, 2026 • edited by MadLittleMods Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Uh oh!

MadLittleMods Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

FrenchGithubUser Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MadLittleMods commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

FrenchGithubUser commented Apr 23, 2026 •

edited by MadLittleMods

Loading