Skip to content

Fix Build and push complement image CI job not having Poetry for complement.sh #19578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MadLittleMods merged 5 commits into from
Mar 17, 2026
Merged

Fix Build and push complement image CI job not having Poetry for complement.sh #19578

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a0e52e
Fix `Build and push complement image` CI job not having Poetry for `c…
MadLittleMods Mar 17, 2026
0abcad9
Add changelog
MadLittleMods Mar 17, 2026
a26259d
Merge branch 'develop' into madlittlemods/fix-complement-push-image-c…
MadLittleMods Mar 17, 2026
bef53ef
Merge branch 'develop' into madlittlemods/fix-complement-push-image-c…
MadLittleMods Mar 17, 2026
25ebe50
Align `poetry` version
MadLittleMods Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/push_complement_image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ jobs:
if: github.event_name == 'push'
with:
ref: master
# We use `poetry` in `complement.sh`
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2.0.0
with:
poetry-version: "2.1.1"
Comment thread
MadLittleMods marked this conversation as resolved.
Outdated
- name: Login to registry
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
with:
Expand Down
1 change: 1 addition & 0 deletions changelog.d/19578.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix `Build and push complement image` CI job not having `poetry` available for the Complement runner script.

@MadLittleMods MadLittleMods Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is actually passing now ✅ : https://github.com/element-hq/synapse/actions/runs/23176910722/job/67341095251 (using the testing strategy from the PR description)

Loading