[crowdstrike] Declare ANODE anomaly numeric leaves as float (falcon, fdr, alert)#20305
Conversation
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
4acee32 to
a43f22f
Compare
45c24fc to
ed1104c
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
ed1104c to
4539222
Compare
|
No issues across the latest commits 4539222.
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
efd6
left a comment
There was a problem hiding this comment.
Please add/modify system test events to test this.
…fdr, alert) CrowdStrike's ANODE anomaly indicators carry numeric values that are usually decimals but occasionally whole numbers. These leaves weren't declared in the package, so each index inferred the type from the first value seen — an integer-first index mapped the field as long and later decimals were rejected to the failure store. Declaring them float across the falcon, fdr, and alert data streams fixes the type regardless of ingest order. Co-authored-by: Cursor <cursoragent@cursor.com>
Add data-protection events carrying fractional ANODE values to the pipeline tests for all three data streams, plus end-to-end system-test events for the falcon logfile input and the alert CEL mock, exercising the float leaves declared in the previous commit. Co-authored-by: Cursor <cursoragent@cursor.com>
4539222 to
ae9b5b5
Compare
|
@efd6 added test events that exercise the new float leaves |
|
|
|
/test |
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
|
Tick the box to add this pull request to the merge queue (same as
|
|
Package crowdstrike - 4.4.1 containing this change is available at https://epr.elastic.co/package/crowdstrike/4.4.1/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
The managed data stream runs with
index.mapping.coerce: false, so a decimal can't be squeezed into alongfield —it's rejected outright:
The first document locks the field to
long; the second is rejected. With thefloatdeclaration both index cleanly.Then run
elastic-package buildandelastic-package test pipeline -C packages/crowdstrike.Related issues