Supabase OpenTelemetry Integration Package - #20130
Conversation
Elastic Docs Style Checker (Vale)Summary: 3 warnings, 1 suggestion found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/supabase/_dev/build/docs/README.md | 77 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/supabase/manifest.yml | 105 | Elastic.MenuArrows | Use '→' to separate menu items, not '' or '='. Example: Select Manage index → Add lifecycle policy. |
| packages/supabase/manifest.yml | 105 | Elastic.MenuArrows | Use '→' to separate menu items, not '' or '='. Example: Select Manage index → Add lifecycle policy. |
💡 Suggestions (1): Optional style improvements. Apply when helpful.
| File | Line | Rule | Message |
|---|---|---|---|
| packages/supabase/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
This comment has been minimized.
This comment has been minimized.
TL;DRThe Remediation
Investigation detailsRoot CauseNot determinable from the available package log. The log ends the test phase with Evidence
Verification
Follow-upOnce the first package-test error is available, trace it against the PR head diff and update the remediation with the exact file and line. What is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
teresaromero
left a comment
There was a problem hiding this comment.
I've tried to build the package and the bundle looks good. I've installed into a 9.4.4 stack and i see variables and options as expected.
However, i encourage to have a good set of tests for the data streams so there is a clear expectation and good review that all is set as expected. Could you add policy tests and some default system tests with a basic mock service? If i recall correctly supabase can be set with a docker environment, so we should be able to check this out?
| - package: prometheus_input_otel | ||
| version: "0.1.1" | ||
| content: | ||
| - package: supabase_otel |
There was a problem hiding this comment.
when installing this with elastic-package stack up i get an error, this package is not available yet? also, i have not seen it locally.
There was a problem hiding this comment.
YEs this package will be merged soon.
Also say if we update the version on content package with some change. I am hoping this package automatically undestands to always pick the latest pacakge. Or is it expected to change the version of the content packa here too.
Version should be a minimum version criteria imo. Else it should always pick the latest
@teresaromero
|
@mrodm @teresaromero Do you have any suggestion on how to go about it ? |
mykola-elastic
left a comment
There was a problem hiding this comment.
Configuration was pretty straightforward to me and it worked. LGTM
teresaromero
left a comment
There was a problem hiding this comment.
This package depends on #20265 being on EPR; on install time. I guess it can be released but for prod use the content pack should be available.
This is not surfacing here because there is no system test that requires package installation, just build. Composable packages require only inputs, content dependencies are downloaded by fleet.
|
Tick the box to add this pull request to the merge queue (same as
|
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
|
Package supabase - 0.1.0 containing this change is available at https://epr.elastic.co/package/supabase/0.1.0/ |
Supabase OpenTelemetry Integration (Composable package)
This package depends upon the prometheus_input_otel and the supabase_otel content package.
Related Issue: https://github.com/elastic/obs-integration-team/issues/1153