Skip to content

Fix viewpoint-adapted varargs type #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aosen-xiong wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Fix viewpoint-adapted varargs type #903

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5d3c189
Invoke viewpoint adapter at correct place
aosen-xiong Sep 9, 2024
df8a262
Merge branch 'master' into invoke-viewpointadapter-constructor
aosen-xiong Sep 9, 2024
8228faa
Invoke viewpointAdaptConstructor also for super constructor
aosen-xiong Sep 30, 2024
56dde2f
Merge branch 'master' into invoke-viewpointadapter-constructor
aosen-xiong Sep 30, 2024
eb4e7c0
Merge branch 'master' into invoke-viewpointadapter-constructor
aosen-xiong Jun 20, 2026
c2b1bf1
Fix viewpoint-adapted varargs type
aosen-xiong Jun 20, 2026
0d9cde6
Merge branch 'master' into invoke-viewpointadapter-constructor
aosen-xiong Jul 16, 2026
d6adf2e
Merge branch 'master' into invoke-viewpointadapter-constructor
wmdietl Jul 17, 2026
bffeb0d
Wording tweaks
wmdietl Jul 17, 2026
5a2db67
Merge branch 'master' into invoke-viewpointadapter-constructor
aosen-xiong Jul 24, 2026
465269b
Allow empty varargs calls without issuing varargs.type.incompatible
aosen-xiong Jul 24, 2026
be684d3
Extract overridable shouldCheckVarargs from checkVarargs and override…
aosen-xiong Jul 24, 2026
5192106
Merge branch 'master' into invoke-viewpointadapter-constructor
aosen-xiong Jul 25, 2026
f073243
Clean up comment line formatting in ValueVisitor.java
aosen-xiong Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Other improvements and bug fixes:

**Closed issues:**

eisop#433, eisop#792, eisop#863, eisop#1801.
eisop#386, eisop#433, eisop#792, eisop#863, eisop#1801.


Version 3.49.5-eisop1 (April 26, 2026)
Expand Down
2 changes: 2 additions & 0 deletions framework/src/main/java/org/checkerframework/framework/type/AbstractViewpointAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ public void viewpointAdaptConstructor(
constructorType.setParameterTypes(unsubstitutedConstructorType.getParameterTypes());
constructorType.setTypeVariables(unsubstitutedConstructorType.getTypeVariables());
constructorType.setReturnType(unsubstitutedConstructorType.getReturnType());
constructorType.computeVarargType();
}

@Override
Expand Down Expand Up @@ -189,6 +190,7 @@ public void viewpointAdaptMethod(
methodType.setReceiverType(unsubstitutedMethodType.getReceiverType());
methodType.setParameterTypes(unsubstitutedMethodType.getParameterTypes());
methodType.setTypeVariables(unsubstitutedMethodType.getTypeVariables());
methodType.computeVarargType();
}

/**
Expand Down
29 changes: 29 additions & 0 deletions framework/tests/viewpointtest/Issue386.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Test case for EISOP issue #386:
// https://github.com/eisop/checker-framework/issues/386
import viewpointtest.quals.*;

public class Issue386 {
public class Inner {
Inner() {}

Inner(@ReceiverDependentQual Object... args) {}
}

public class MethodReceiver {
void method(@ReceiverDependentQual Object... args) {}
}

@SuppressWarnings("cast.unsafe.constructor.invocation")
public void constructorTest(@A Object aObj, @A Object otherAObj, @B Object bObj) {
this.new @A Inner(aObj, otherAObj);
// :: error: (argument.type.incompatible)
Comment thread
aosen-xiong marked this conversation as resolved.
this.new @A Inner(aObj, bObj);
}

public void methodTest(
@A MethodReceiver receiver, @A Object aObj, @A Object otherAObj, @B Object bObj) {
receiver.method(aObj, otherAObj);
// :: error: (argument.type.incompatible)
Comment thread
aosen-xiong marked this conversation as resolved.
receiver.method(aObj, bObj);
}
}
8 changes: 5 additions & 3 deletions framework/tests/viewpointtest/VarargsConstructor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ void foo() {
void invokeConstructor(@A Object aObj, @B Object bObj, @Top Object topObj) {
@A Object a = new @A VarargsConstructor(aObj);
@B Object b = new @B VarargsConstructor(bObj);
// :: error: (argument.type.incompatible) :: error: (new.class.type.invalid)
// :: error: (argument.type.incompatible) :: error: (new.class.type.invalid) :: error:
// (varargs.type.incompatible)
@Top Object top = new @Top VarargsConstructor(topObj);
// :: error: (argument.type.incompatible)
new @A VarargsConstructor(bObj);
Expand All @@ -30,7 +31,7 @@ class Inner {
@ReceiverDependentQual Inner(@ReceiverDependentQual Object... args) {}

void foo() {
// :: error: (new.class.type.invalid)
// :: error: (new.class.type.invalid) :: error: (varargs.type.incompatible)

@wmdietl wmdietl Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the intuition behind this new error? There are no arguments to this constructor invocation, so what is incompatible?

@aosen-xiong aosen-xiong Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The err msg is:

VarargsConstructor.java:35: error: [new.class.type.invalid]
type annotation [@Lost] can not be applied to object creation

VarargsConstructor.java:35: error: [varargs.type.incompatible]
incompatible types in varargs.
  found   : @Lost Object @Top []
  required: @Lost Object @Top []

A zero-argument varargs invocation still creates an implicit empty array. The error occurs because viewpoint adaptation produces @Lost, which is non-reflexive in this test checker. With #1173, the error would be gone.

@wmdietl wmdietl Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the connection to #1173? 1173 is about lost receivers for poly declared receiver methods. This is about arrays?

If the var args array is definitely empty, the Lost component type cannot do any harm. It seems overly conservative to forbid this call, doesn't it?

@aosen-xiong aosen-xiong Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because in #1173 we changed Lost to be a subtype of Lost, this varags.type.incompatible error message will be gone.

Okay, I see your points.

I think even after the change in #1173, we should have

  1. If the argument is empty, allow the call.
  2. If the argument is not empty and the var arg is adapted to have a lost type, reject the call.

Inner a = new Inner();
// :: warning: (cast.unsafe.constructor.invocation)
Inner b = new @A Inner(new @A Object());
Expand All @@ -42,7 +43,8 @@ void foo() {
void invokeConstructor(@A Object aObj, @B Object bObj, @Top Object topObj) {
@A Object a = new @A Inner(aObj);
@B Object b = new @B Inner(bObj);
// :: error: (argument.type.incompatible) :: error: (new.class.type.invalid)
// :: error: (argument.type.incompatible) :: error: (new.class.type.invalid) :: error:
// (varargs.type.incompatible)
@Top Object top = new @Top Inner(topObj);
// :: error: (argument.type.incompatible)
new @A Inner(bObj);
Expand Down
Loading