Skip to content

fix kick vote : correct NO input and make NO votes count - #957

Open
jeezstayawei wants to merge 1 commit into
efroemling:mainfrom
jeezstayawei:fix/kick-vote
Open

fix kick vote : correct NO input and make NO votes count#957
jeezstayawei wants to merge 1 commit into
efroemling:mainfrom
jeezstayawei:fix/kick-vote

Conversation

@jeezstayawei

Copy link
Copy Markdown

hey, noticed a couple issues with the kick vote system so i pushed a quick fix:

  1. the game tells you to type '0' to vote no, but the code was actually looking for '2'. typing 0 literally did nothing. i changed the handler to just accept '0' to match the screen.
  2. even if people did vote no, the no_votes variable was completely ignored in the final math (basically a placebo). i changed it so no_votes actually subtracts from yes_votes so the votes actually count now.

- The display text tells players to type '0' for NO, but the handler only accepted '1' or '2'. Changed the handler to accept '0' instead of '2' to match the display text.

- NO votes were tallied but never used in the vote calculation. Now NO votes subtract from YES votes so they actually affect the outcome.
@Loup-Garou911XD

Copy link
Copy Markdown
Collaborator

This feels like deja vu

@Loup-Garou911XD

Copy link
Copy Markdown
Collaborator

Maybe it was #793 that I am remembering

@jeezstayawei

Copy link
Copy Markdown
Author

Maybe it was #793 that I am remembering
they jus changed from 0 to 2 but even the '2' just gets consumed in game and they didnt fix it, this commit fixes it

@Loup-Garou911XD

Copy link
Copy Markdown
Collaborator

they jus changed from 0 to 2 but even the '2' just gets consumed in game and they didnt fix it, this commit fixes it

There was a big discussion about it somewhere, probably on discord, so i am surprised they didn't get the correct fix applied and all the ppl missed it aswell

@jeezstayawei

Copy link
Copy Markdown
Author

they jus changed from 0 to 2 but even the '2' just gets consumed in game and they didnt fix it, this commit fixes it

There was a big discussion about it somewhere, probably on discord, so i am surprised they didn't get the correct fix applied and all the ppl missed it aswell

btw since you're a collaborator, do you think this is good to merge? I'm totally new to open source and game modding, this is actually my first ever pr

@Loup-Garou911XD

Copy link
Copy Markdown
Collaborator

btw since you're a collaborator, do you think this is good to merge? I'm totally new to open source and game modding, this is actually my first ever pr

Sorry i haven't seen the code, and prolly won't be able to review it rn
Busy with office
And dw, it's nothing serious.Eric is a chill guy
If there is something that needs changing then Eric will let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants