fix kick vote : correct NO input and make NO votes count - #957
fix kick vote : correct NO input and make NO votes count#957jeezstayawei wants to merge 1 commit into
Conversation
- The display text tells players to type '0' for NO, but the handler only accepted '1' or '2'. Changed the handler to accept '0' instead of '2' to match the display text. - NO votes were tallied but never used in the vote calculation. Now NO votes subtract from YES votes so they actually affect the outcome.
|
This feels like deja vu |
|
Maybe it was #793 that I am remembering |
|
There was a big discussion about it somewhere, probably on discord, so i am surprised they didn't get the correct fix applied and all the ppl missed it aswell |
btw since you're a collaborator, do you think this is good to merge? I'm totally new to open source and game modding, this is actually my first ever pr |
Sorry i haven't seen the code, and prolly won't be able to review it rn |
hey, noticed a couple issues with the kick vote system so i pushed a quick fix:
no_votesvariable was completely ignored in the final math (basically a placebo). i changed it sono_votesactually subtracts fromyes_votesso the votes actually count now.