fix two unbounded-loop hangs#201
Conversation
|
add tests |
Add cycle detection to resolve_type_name and resolve_type_descriptor in compiler.py so that circular tagged types raise CompileError instead of looping forever. Add a missing check_decode_error call in ArrayType.decode_content (der.py) so that malformed SEQUENCE OF / SET OF data raises DecodeTagError instead of looping forever. Change-Id: I932de2937f9c68b14e99b3eddc9e919d641e675b
2b1e99a to
1d0c56f
Compare
|
tests added This failed outside my changes, likely due to pyparsing version mismatch in my environment tests/test_compile.py::Asn1ToolsCompileTest::test_cache PASSED [ 2%] |
|
nice, any chance you can make the code styling/formatting look more like the rest of the code? Remove some doc strings, put blank lines in correct positions. |
PR re-issue using correct master branch
Add cycle detection to resolve_type_name and resolve_type_descriptor in compiler.py so that circular tagged types raise CompileError instead of looping forever.
Add a missing check_decode_error call in ArrayType.decode_content (der.py) so that malformed SEQUENCE OF / SET OF data raises DecodeTagError instead of looping forever.