Skip to content

Prevent escaping in xer and jer output#158

Open
f-ohler wants to merge 2 commits into
eerimoq:masterfrom
f-ohler:master
Open

Prevent escaping in xer and jer output#158
f-ohler wants to merge 2 commits into
eerimoq:masterfrom
f-ohler:master

Conversation

@f-ohler

@f-ohler f-ohler commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

Currently the JER and XER encoder escapes non-ascii characters.
ISO/IEC 8825-4:2015 clause 8.1.3 and ISO/IEC 8825-8:2015 clause 7.6.2 demand that both outputs should use UTF-8.

Escaping seems to be allowed for XER, but is forbidden in CXER.
Escaping seems to be allowed for JER.
So, this is probably not a bug.

In my eyes, using the escaping mechanism makes no sense here and leads to less readable output (readability for a human is one of the key features of these encodings).
This PR prevents this escaping mechanism.

If for any reason the current behaviour is beneficial, I suggest adding a further parameter (similar to indent) to control the escaping behaviour.

@f-ohler f-ohler changed the title Make xer and jer output utf-8 Prevent escaping in xer and jer output Jan 3, 2023
@codecov

codecov Bot commented Jan 3, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.18%. Comparing base (349e9a7) to head (12f34ca).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   35.18%   35.18%           
=======================================
  Files           7        7           
  Lines        8567     8567           
=======================================
  Hits         3014     3014           
  Misses       5553     5553           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage: 96.47%. Remained the same when pulling 12f34ca on muued:master into 349e9a7 on eerimoq:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants