fix: prevent React 418 hydration mismatch on compare tools and client-only components - #670
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes React error #418 (hydration mismatch) when navigating or opening tool pages while tools are saved in comparison storage (
localStorage).Changes
useCompareToolsandCompareToolsPanel:useHasMountedhook to safely defer client-only state derived from browserlocalStorageuntil after the component has mounted.[]), ensuringisSelectedandisLimitReachedmatch the server-rendered HTML.<CompareToolsPanel />withif (!hasMounted || effectiveSelectedTools.length === 0) return null;so that the floating panel is not rendered during initial hydration when SSR returnednull.withClientOnlyHOC:__SERVER__ ? null : <WrappedComponent />check with a post-mount lifecycle guard (useState(false)+useEffect), preventing server/client tree mismatches during initial client hydration.useHasMountedandhasMountedinutils.test.jsx.withClientOnlyinwithClientOnly.test.jsx.