Conversation
Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
🟢 Approval recommended
Change is narrowly scoped to a single constant used by the “Open IDE” step and aligns with the stated goal of avoiding premature timeout errors.
Pull request overview
This PR increases the workspace startup “Open IDE” step timeout by extending TIMEOUT_TO_GET_URL_SEC from 20s to 40s, reducing false failures on slow clusters (e.g., cold image pulls / higher latency).
Changes:
- Increased
TIMEOUT_TO_GET_URL_SECfrom 20 to 40 seconds inWorkspaceProgressconstants.
File summaries
| File | Description |
|---|---|
| packages/dashboard-frontend/src/components/WorkspaceProgress/const.ts | Extends IDE URL wait timeout constant from 20s to 40s to better accommodate slow startup conditions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1671 (linux/amd64, linux/arm64, linux/s390x) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1671", name: che-dashboard}]}}]" |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 609 609
Lines 63875 63875
Branches 5015 5015
=======================================
Hits 59052 59052
Misses 4758 4758
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What does this PR do?
Increases the IDE URL timeout from 20 to 40 seconds during workspace startup.
Root Cause
When a workspace starts on a slow cluster or pulls a large editor image,
the IDE URL may not be available within 20 seconds. The
TIMEOUT_TO_GET_URL_SECconstant in
WorkspaceProgress/const.tscontrols how long the "Open IDE" stepwaits before showing an error. 20 seconds is too aggressive for environments
with cold image pulls or high API latency.
Fix
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
fixes https://redhat.atlassian.net/browse/CRW-12569
Is it tested? How?
Unit tests in
StartingSteps/OpenWorkspace/__tests__/index.spec.tsx(12 tests) cover the timeout value and error message.Manual verification:
Release Notes
Extended the IDE URL timeout from 20 to 40 seconds to prevent false startup errors on slower clusters.
Docs PR
N/A