[cherry-pick] fix: fetch getting-started-sample regardless of disableInternalRegistry - #1669
Merged
Conversation
The disableInternalRegistry flag is meant to hide only the built-in airgap samples, not user-provided samples from ConfigMaps. A recent refactor accidentally gated both endpoints behind the same condition, leaving the Get Started page empty when custom samples were the only source. Fixes: https://redhat.atlassian.net/browse/CRW-13015 Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
Contributor
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1669 (linux/amd64, linux/arm64, linux/s390x) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1669", name: che-dashboard}]}}]" |
svor
approved these changes
Sep 10, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes empty Get Started sample cards when
disableInternalRegistry: trueis set in the CheCluster CR.cherry-pick of #1668 to the 7.121.x branch
What issues does this PR fix or reference?
fixes https://redhat.atlassian.net/browse/CRW-13015
Is it tested? How?
spec.components.devfileRegistry.disableInternalRegistry: truein the CheCluster CR.getting-started-samplesConfigMap with custom sample entries.disableInternalRegistryis true and no external registries are configured.Release Notes
N/A - regression fix; no user-facing changes.
Docs PR
N/A