Skip to content

refactor: consolidate waveform and encoding validation - #1746

Open
tomatotomata wants to merge 3 commits into
echostack-org:mainfrom
tomatotomata:codex/issue-1745-consolidate-validation
Open

refactor: consolidate waveform and encoding validation#1746
tomatotomata wants to merge 3 commits into
echostack-org:mainfrom
tomatotomata:codex/issue-1745-consolidate-validation

Conversation

@tomatotomata

Copy link
Copy Markdown

Summary

  • move waveform and encoding combination validation into calibrate.utils
  • reuse the helper from calibration and Simrad beam selection
  • add unit coverage for valid and invalid combinations

Closes #1745

Validation

  • python -m compileall -q echopype
  • git diff --check

The full test environment is not available in this Windows checkout.

@LOCEANlloydizard
LOCEANlloydizard marked this pull request as ready for review August 6, 2026 17:45
@LOCEANlloydizard LOCEANlloydizard moved this from Todo to In Review in Echopype 2026 Aug 8, 2026
@LOCEANlloydizard LOCEANlloydizard added this to the v0.12.0 milestone Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Consolidate input argument combination checking for EK80 data

2 participants