feat(notifications): sync filter tabs and push toggles across all types

src/components/notification/view/notificationView.tsx

@@ -16,14 +16,26 @@ import { selectIsDarkTheme } from '../../../redux/selectors';
 import styles from './notificationStyles';
 
 // Each `key` must match a NotificationFilters enum value (passed straight to the
-// notifications query) and have a `notification.<key>` locale string, which is
-// also the displayed label — so the key is the single source for both.
+// notifications query) and have a `notification.filters.<key>` locale string.
+// Labels live under their own `filters` namespace rather than reusing
+// `notification.<key>`: several of those are notification BODY strings
+// (`payouts` is "Payout received: ${amount}", `delegations` is "delegated"), so
+// using them as labels renders template text in the dropdown.
 const FILTERS = [
   { key: 'activities' },
   { key: 'replies' },
   { key: 'mentions' },
   { key: 'rvotes' },
   { key: 'follows' },
+  { key: 'reblogs' },
+  { key: 'transfers' },
+  { key: 'delegations' },
+  { key: 'nfavorites' },
+  { key: 'nbookmarks' },
+  { key: 'payouts' },
+  { key: 'scheduled_published' },
+  { key: 'account_updates' },
+  { key: 'weekly_earnings' },
 ];
 
 interface Props {
@@ -113,7 +125,7 @@ const NotificationView = ({
       <FilterBar
         dropdownIconName="arrow-drop-down"
         options={FILTERS.map((item) =>
-          intl.formatMessage({ id: `notification.${item.key}` }).toUpperCase(),
+          intl.formatMessage({ id: `notification.filters.${item.key}` }).toUpperCase(),
         )}
         defaultText="ALL"
         onDropdownSelect={_handleOnDropdownSelect}

src/config/locales/en-US.json

@@ -373,6 +373,22 @@
     "selected": "Selected {postfix}"
   },
   "notification": {
+    "filters": {
+      "activities": "All",
+      "replies": "Replies",
+      "mentions": "Mentions",
+      "rvotes": "Votes",
+      "follows": "Follows",
+      "reblogs": "Reblogs",
+      "transfers": "Transfers",
+      "delegations": "Delegations",
+      "nfavorites": "Favorites",
+      "nbookmarks": "Bookmarks",
+      "payouts": "Payouts",
+      "scheduled_published": "Scheduled posts",
+      "account_updates": "Account updates",
+      "weekly_earnings": "Weekly earnings"
+    },
     "this_week": "This Week",
     "reblog": "reblogged",
     "unfollow": "unfollowed you",
@@ -1581,6 +1597,9 @@
       "vote": "Vote",
       "follow": "Follow",
       "scheduled_published": "Scheduled post published",
+      "payouts": "Payouts",
+      "account_update": "Account updates",
+      "weekly_earnings": "Weekly earnings",
       "fcm_unavailable": "Push notifications are not supported on this device. You will receive notifications only while the app is open."
     },
     "keys_warning": "Sensitive account information!\nEcency must be secured with PIN code before viewing private keys.",

src/providers/ecency/ecency.types.ts

@@ -185,6 +185,12 @@ export enum NotificationFilters {
   DELEGATIONS = 'delegations',
   FAVOURITES = 'nfavorites',
   BOOKMARKS = 'nbookmarks',
+  PAYOUTS = 'payouts',
+  SCHEDULED_PUBLISHED = 'scheduled_published',
+  // Filter path is plural while the notification `type` string is singular
+  // (`account_update`) — enotify routes on the plural form.
+  ACCOUNT_UPDATES = 'account_updates',
+  WEEKLY_EARNINGS = 'weekly_earnings',
 }
 
 export enum PointActivityIds {

src/redux/actions/applicationActions.ts

@@ -9,6 +9,10 @@ import {
   CHANGE_REBLOG_NOTIFICATION,
   CHANGE_TRANSFERS_NOTIFICATION,
   CHANGE_SCHEDULED_PUBLISHED_NOTIFICATION,
+  CHANGE_DELEGATIONS_NOTIFICATION,
+  CHANGE_PAYOUTS_NOTIFICATION,
+  CHANGE_ACCOUNT_UPDATE_NOTIFICATION,
+  CHANGE_WEEKLY_EARNINGS_NOTIFICATION,
   CHANGE_ALL_NOTIFICATION_SETTINGS,
   CHANGE_VOTE_NOTIFICATION,
   IS_CONNECTED,
@@ -140,6 +144,30 @@ export const changeNotificationSettings = (payload) => {
         type: CHANGE_SCHEDULED_PUBLISHED_NOTIFICATION,
       };
 
+    case 'notification.delegations':
+      return {
+        payload: payload.action,
+        type: CHANGE_DELEGATIONS_NOTIFICATION,
+      };
+
+    case 'notification.payouts':
+      return {
+        payload: payload.action,
+        type: CHANGE_PAYOUTS_NOTIFICATION,
+      };
+
+    case 'notification.accountUpdate':
+      return {
+        payload: payload.action,
+        type: CHANGE_ACCOUNT_UPDATE_NOTIFICATION,
+      };
+
+    case 'notification.weeklyEarnings':
+      return {
+        payload: payload.action,
+        type: CHANGE_WEEKLY_EARNINGS_NOTIFICATION,
+      };
+
     case 'notification':
       return {
         payload: payload.action,

src/redux/constants/constants.ts

@@ -34,6 +34,10 @@ export const CHANGE_BOOKMARK_NOTIFICATION = 'CHANGE_BOOKMARK_NOTIFICATION';
 export const CHANGE_REBLOG_NOTIFICATION = 'CHANGE_REBLOG_NOTIFICATION';
 export const CHANGE_TRANSFERS_NOTIFICATION = 'CHANGE_TRANSFERS_NOTIFICATION';
 export const CHANGE_SCHEDULED_PUBLISHED_NOTIFICATION = 'CHANGE_SCHEDULED_PUBLISHED_NOTIFICATION';
+export const CHANGE_DELEGATIONS_NOTIFICATION = 'CHANGE_DELEGATIONS_NOTIFICATION';
+export const CHANGE_PAYOUTS_NOTIFICATION = 'CHANGE_PAYOUTS_NOTIFICATION';
+export const CHANGE_ACCOUNT_UPDATE_NOTIFICATION = 'CHANGE_ACCOUNT_UPDATE_NOTIFICATION';
+export const CHANGE_WEEKLY_EARNINGS_NOTIFICATION = 'CHANGE_WEEKLY_EARNINGS_NOTIFICATION';
 export const CHANGE_ALL_NOTIFICATION_SETTINGS = 'CHANGE_ALL_NOTIFICATION_SETTINGS';
 export const SET_LAST_APP_VERSION = 'SET_LAST_APP_VERSION';
 export const SET_COLOR_THEME = 'SET_COLOR_THEME';

src/redux/reducers/applicationReducer.ts

@@ -10,6 +10,10 @@ import {
   CHANGE_REBLOG_NOTIFICATION,
   CHANGE_TRANSFERS_NOTIFICATION,
   CHANGE_SCHEDULED_PUBLISHED_NOTIFICATION,
+  CHANGE_DELEGATIONS_NOTIFICATION,
+  CHANGE_PAYOUTS_NOTIFICATION,
+  CHANGE_ACCOUNT_UPDATE_NOTIFICATION,
+  CHANGE_WEEKLY_EARNINGS_NOTIFICATION,
   CHANGE_VOTE_NOTIFICATION,
   CHANGE_ALL_NOTIFICATION_SETTINGS,
   IS_CONNECTED,
@@ -76,6 +80,10 @@ interface State {
     transfersNotification: boolean;
     voteNotification: boolean;
     scheduledPublishedNotification: boolean;
+    delegationsNotification: boolean;
+    payoutsNotification: boolean;
+    accountUpdateNotification: boolean;
+    weeklyEarningsNotification: boolean;
   };
   postUpvotePercent: number;
   commentUpvotePercent: number;
@@ -122,6 +130,10 @@ const initialState: State = {
     transfersNotification: true,
     voteNotification: true,
     scheduledPublishedNotification: true,
+    delegationsNotification: true,
+    payoutsNotification: true,
+    accountUpdateNotification: true,
+    weeklyEarningsNotification: true,
   },
   postUpvotePercent: 1,
   commentUpvotePercent: 1,
@@ -238,6 +250,34 @@ const applicationReducer = (state = initialState, action): State => {
           scheduledPublishedNotification: action.payload,
         },
       });
+    case CHANGE_DELEGATIONS_NOTIFICATION:
+      return Object.assign({}, state, {
+        notificationDetails: {
+          ...state.notificationDetails,
+          delegationsNotification: action.payload,
+        },
+      });
+    case CHANGE_PAYOUTS_NOTIFICATION:
+      return Object.assign({}, state, {
+        notificationDetails: {
+          ...state.notificationDetails,
+          payoutsNotification: action.payload,
+        },
+      });
+    case CHANGE_ACCOUNT_UPDATE_NOTIFICATION:
+      return Object.assign({}, state, {
+        notificationDetails: {
+          ...state.notificationDetails,
+          accountUpdateNotification: action.payload,
+        },
+      });
+    case CHANGE_WEEKLY_EARNINGS_NOTIFICATION:
+      return Object.assign({}, state, {
+        notificationDetails: {
+          ...state.notificationDetails,
+          weeklyEarningsNotification: action.payload,
+        },
+      });
     case CHANGE_VOTE_NOTIFICATION:
       return Object.assign({}, state, {
         notificationDetails: {

src/redux/store/store.ts

@@ -50,7 +50,7 @@ const persistConfig = {
   key: 'root',
   // Storage Method (React Native)
   storage: AsyncStorage,
-  version: 20, // v20: Default scheduledPublished notification ON, backfill bookmark setting
+  version: 21, // v21: Default delegations/payouts/accountUpdate/weeklyEarnings notifications ON
   // // Blacklist (Don't Save Specific Reducers)
   blacklist: ['communities', 'user', 'ui'],
   transforms: [transformCacheVoteMap, transformWalkthroughMap],

src/screens/application/container/applicationContainer.tsx

@@ -1078,6 +1078,10 @@ class ApplicationContainer extends Component {
         transfersNotification: 6,
         favoriteNotification: 13,
         bookmarkNotification: 15,
+        delegationsNotification: 10,
+        payoutsNotification: 19,
+        accountUpdateNotification: 20,
+        weeklyEarningsNotification: 21,
         scheduledPublishedNotification: 22,
       };
 

src/screens/login/container/loginContainer.tsx

@@ -255,6 +255,10 @@ class LoginContainer extends PureComponent {
       transfers: 6,
       favorite: 13,
       bookmark: 15,
+      delegations: 10,
+      payouts: 19,
+      accountUpdate: 20,
+      weeklyEarnings: 21,
       scheduledPublished: 22,
     };
     const notifyTypes = [];

src/screens/settings/container/settingsContainer.tsx

@@ -538,6 +538,10 @@ class SettingsContainer extends Component {
       transfers: 6,
       favorite: 13,
       bookmark: 15,
+      delegations: 10,
+      payouts: 19,
+      accountUpdate: 20,
+      weeklyEarnings: 21,
       scheduledPublished: 22,
     };
     const notifyTypes = [];
@@ -888,6 +892,10 @@ const mapStateToProps = (state) => {
     transfersNotification: notificationDetails.transfersNotification,
     voteNotification: notificationDetails.voteNotification,
     scheduledPublishedNotification: notificationDetails.scheduledPublishedNotification,
+    delegationsNotification: notificationDetails.delegationsNotification,
+    payoutsNotification: notificationDetails.payoutsNotification,
+    accountUpdateNotification: notificationDetails.accountUpdateNotification,
+    weeklyEarningsNotification: notificationDetails.weeklyEarningsNotification,
     selectedApi: selectApi(state),
     selectedCurrency: selectCurrency(state),
     selectedLanguage: selectLanguage(state),

src/screens/settings/screen/settingsScreen.tsx

@@ -53,6 +53,10 @@ const SettingsScreen = ({
   transfersNotification,
   voteNotification,
   scheduledPublishedNotification,
+  delegationsNotification,
+  payoutsNotification,
+  accountUpdateNotification,
+  weeklyEarningsNotification,
   handleOnButtonPress,
   isLoading,
   isHideImages,
@@ -347,6 +351,42 @@ const SettingsScreen = ({
                 isOn={scheduledPublishedNotification}
                 handleOnChange={handleOnChange}
               />
+              <SettingsItem
+                title={intl.formatMessage({
+                  id: 'settings.notification.delegations',
+                })}
+                type="toggle"
+                actionType="notification.delegations"
+                isOn={delegationsNotification}
+                handleOnChange={handleOnChange}
+              />
+              <SettingsItem
+                title={intl.formatMessage({
+                  id: 'settings.notification.payouts',
+                })}
+                type="toggle"
+                actionType="notification.payouts"
+                isOn={payoutsNotification}
+                handleOnChange={handleOnChange}
+              />
+              <SettingsItem
+                title={intl.formatMessage({
+                  id: 'settings.notification.account_update',
+                })}
+                type="toggle"
+                actionType="notification.accountUpdate"
+                isOn={accountUpdateNotification}
+                handleOnChange={handleOnChange}
+              />
+              <SettingsItem
+                title={intl.formatMessage({
+                  id: 'settings.notification.weekly_earnings',
+                })}
+                type="toggle"
+                actionType="notification.weeklyEarnings"
+                isOn={weeklyEarningsNotification}
+                handleOnChange={handleOnChange}
+              />
             </CollapsibleCard>
             {isFCMAvailable === false && (
               <View

src/utils/migrationHelpers.test.ts

@@ -424,6 +424,36 @@ describe('reduxMigrations', () => {
     });
   });
 
+  describe('v21: delegations/payouts/accountUpdate/weeklyEarnings notification defaults', () => {
+    it('defaults the four newly-toggleable notification settings ON when missing', () => {
+      const state = { application: { notificationDetails: { voteNotification: false } } } as any;
+      const result = reduxMigrations[21](state);
+      const details = result.application.notificationDetails;
+      expect(details.delegationsNotification).toBe(true);
+      expect(details.payoutsNotification).toBe(true);
+      expect(details.accountUpdateNotification).toBe(true);
+      expect(details.weeklyEarningsNotification).toBe(true);
+      // existing settings are untouched
+      expect(details.voteNotification).toBe(false);
+    });
+
+    it('preserves an explicit false', () => {
+      const state = {
+        application: { notificationDetails: { payoutsNotification: false } },
+      } as any;
+      const result = reduxMigrations[21](state);
+      expect(result.application.notificationDetails.payoutsNotification).toBe(false);
+      expect(result.application.notificationDetails.delegationsNotification).toBe(true);
+    });
+
+    it('is a no-op when notificationDetails is absent', () => {
+      const state = { application: {}, account: { keep: 'me' } } as any;
+      const result = reduxMigrations[21](state);
+      expect(result.application.notificationDetails).toBeUndefined();
+      expect(result.account.keep).toBe('me');
+    });
+  });
+
   describe('failure isolation', () => {
     it('rolls back a throwing migration and preserves the rest of the state', () => {
       // v1 writes state.application.notificationDetails.favoriteNotification; with

src/utils/migrationHelpers.ts

@@ -556,6 +556,20 @@ const reduxMigrations = {
     }
     return state;
   },
+  21: (state) => {
+    // Default the notification types that previously had no push toggle ON for
+    // existing installs, matching every other type (and 20 above): autoMergeLevel1
+    // keeps persisted notificationDetails as-is, so a new key is never picked up
+    // from initialState without a migration.
+    if (state.application?.notificationDetails) {
+      const details = state.application.notificationDetails;
+      details.delegationsNotification = details.delegationsNotification ?? true;
+      details.payoutsNotification = details.payoutsNotification ?? true;
+      details.accountUpdateNotification = details.accountUpdateNotification ?? true;
+      details.weeklyEarningsNotification = details.weeklyEarningsNotification ?? true;
+    }
+    return state;
+  },
 };
 
 // Wrap every migration so a throw degrades to "skip this migration" and keep the