(Re)Add warning for rank deficiency#923
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates check_collinearity() to handle rank-deficient models and issue appropriate warnings. However, there are a few critical issues in the implementation: an undefined variable m is referenced when identifying NA columns, an incorrect logical comparison any(!keep_idx) < ncol(v) is used during matrix subsetting, and a leftover debugonce() statement in the test file needs to be removed to prevent CI test failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The note for rank deficiency was broken, this PR re-establishes it and upgrades it to a warning.
Closes #922