Skip to content

(Re)Add warning for rank deficiency#923

Open
mattansb wants to merge 3 commits into
mainfrom
warning-for-rand-deficiency
Open

(Re)Add warning for rank deficiency#923
mattansb wants to merge 3 commits into
mainfrom
warning-for-rand-deficiency

Conversation

@mattansb

Copy link
Copy Markdown
Member

The note for rank deficiency was broken, this PR re-establishes it and upgrades it to a warning.

Closes #922

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates check_collinearity() to handle rank-deficient models and issue appropriate warnings. However, there are a few critical issues in the implementation: an undefined variable m is referenced when identifying NA columns, an incorrect logical comparison any(!keep_idx) < ncol(v) is used during matrix subsetting, and a leftover debugonce() statement in the test file needs to be removed to prevent CI test failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread R/check_collinearity.R Outdated
Comment thread tests/testthat/test-check_collinearity.R Outdated
Comment thread R/check_collinearity.R Outdated
@mattansb mattansb requested a review from strengejacke July 13, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check_collinearity() and aliases handling

1 participant