-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(sdk): public withOptions / with_params on resource classes #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devin-ai-integration
wants to merge
8
commits into
main
from
devin/1787866410-with-opts-multi-client
+269
−60
Closed
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7d2f0a3
refactor(sdk): bind multi-client config via hidden withOpts/_with_params
devin-ai-integration[bot] a41b0e4
refactor(js-sdk): constrain withOpts receiver to ClientFactory subcla…
devin-ai-integration[bot] 1e836f7
refactor(sdk): rename to bindClientOpts/bind_client_params and merge …
devin-ai-integration[bot] dc0082d
refactor(js-sdk): use named E2BClientOpts type in bindClientOpts and …
devin-ai-integration[bot] 2fbfa35
refactor(sdk): expose binding as standalone bindClientOpts/bind_clien…
devin-ai-integration[bot] 0cf345b
feat(sdk): add client.withOptions / client.with_params returning a ne…
devin-ai-integration[bot] 7c0d70a
feat(sdk): add public withOptions / with_params on resource classes
devin-ai-integration[bot] 80385e7
refactor(sdk): remove withOptions/with_params from the E2B client
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| 'e2b': patch | ||
| '@e2b/python-sdk': patch | ||
| --- | ||
|
|
||
| Rework the multi-client binding: the `E2B` client now builds its resource classes through a hidden `ClientFactory.withOpts` (JS) / `ClientFactory._with_params` (Python) method that returns a subclass with the connection config bound, instead of inlining subclass creation in the client constructor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.