Skip to content

Remove SDK-side defaults from API request payloads - #1749

Open
devin-ai-integration[bot] wants to merge 10 commits into
mainfrom
devin/1787318715-remove-sdk-defaults
Open

Remove SDK-side defaults from API request payloads#1749
devin-ai-integration[bot] wants to merge 10 commits into
mainfrom
devin/1787318715-remove-sdk-defaults

Remove SDK-side defaults from API request payloads

1c4dc53
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 21, 2026 in 8m 9s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit packages/js-sdk/src/template/index.ts:1076-1083 Missing test coverage for template build cpuCount/memoryMB omission

Annotations

Check warning on line 1083 in packages/js-sdk/src/template/index.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Missing test coverage for template build cpuCount/memoryMB omission

Removing SDK-side defaults from `cpuCount`/`memoryMB` changed `requestBuild` in `packages/js-sdk/src/template/index.ts` and `request_build` in both Python `template_sync/build_api.py` / `template_async/build_api.py`, but no test asserts these fields are actually omitted from the template build request body when unset — unlike the new omission tests added for sandbox create/fork/pause in `apiDefaults.test.ts` and `test_api_defaults.py`. This is a coverage gap, not a runtime defect (JSON seriali