test: split Template suites into mocked unit and e2e tiers (4/4) - #1745
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Claude / Claude Code Review
completed
Aug 21, 2026 in 8m 13s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/js-sdk/tests/template/exists.test.ts:1-14 |
Missing E2B_DEBUG skip on control-plane/build e2e tests |
Annotations
Check warning on line 14 in packages/js-sdk/tests/template/exists.test.ts
claude / Claude Code Review
Missing E2B_DEBUG skip on control-plane/build e2e tests
Use `hostedTest` instead of `e2eTest` for tests that hit control-plane/build-only APIs, so `E2B_DEBUG` still skips them -- sweep:`e2eTest\(` (seen in backgroundBuild.test.ts and exists.test.ts). `hostedTest = e2eTest.skipIf(isDebug)` is the variant meant for exactly this case; a local envd cannot service `Template.buildInBackground` or `Template.exists`, so under `E2B_E2E=1` + `E2B_DEBUG` these tests would hit the wrong server and fail/hang instead of skipping, unlike their Python mirrors which
Loading