ci(js-sdk): install Playwright Chromium without --with-deps - #1699
Merged
Claude / Claude Code Review
completed
Aug 19, 2026 in 25m 37s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/js-sdk/package.json:38 |
Dropping --with-deps may break Windows Chromium launch on cache miss |
Annotations
Check warning on line 38 in packages/js-sdk/package.json
claude / Claude Code Review
Dropping --with-deps may break Windows Chromium launch on cache miss
Removing `--with-deps` from the Playwright install (packages/js-sdk/package.json:38) also drops `install_media_pack.ps1`'s `Install-WindowsFeature Server-Media-Foundation` step on Windows, which Chromium's launch-time host validation on Windows Server hard-fails without. This is currently masked because the `actions/cache`-backed Playwright cache still holds a validation marker from before this change, but on the next cache miss (Playwright version bump, cache eviction, or new runner image) the
Loading