fix(sdk): support sending stdin through the PTY command handle - #1502
Open
mishushakov wants to merge 4 commits into
Open
fix(sdk): support sending stdin through the PTY command handle#1502mishushakov wants to merge 4 commits into
mishushakov wants to merge 4 commits into
Claude / Claude Code Review
completed
Jun 29, 2026 in 10m 36s
Code review found 1 potential issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/js-sdk/src/sandbox/commands/pty.ts:266-282 |
Migrate CLI from deprecated pty.sendInput |
Annotations
Check warning on line 282 in packages/js-sdk/src/sandbox/commands/pty.ts
claude / Claude Code Review
Migrate CLI from deprecated pty.sendInput
The CLI at packages/cli/src/terminal.ts:29 still calls the freshly-deprecated `sandbox.pty.sendInput(...)`. Since this PR adds the `@deprecated` marker, it introduces a TypeScript deprecation warning against its own internal consumer — migrating the single call site to `sandbox.pty.sendStdin` keeps the monorepo clean of warnings this PR itself produces. Nit — functionally identical (the alias just delegates).
Loading