Remove aarch64_decode test - #270
Merged
Merged
Conversation
It's now part of the Dyninst integration tests.
hainest
added
the
code cleanup
kupsch
approved these changes
Apr 4, 2026
bbiiggppiigg
added a commit
that referenced
this pull request
Aug 5, 2026
PR #270 removed the body of aarch64_decode.C (the test lives in the Dyninst integration tests now) but left a stub file, the test's specification facts, and its generated RunGroups -- so the empty test was still being scheduled and built. Remove the specification block, the stub, and regenerate the platform directories (the only generated change is the aarch64_decode disk-mode groups disappearing). Also delete files in src/instruction that nothing references: - power_instruction_table.txt / power_instruction_oprands.txt: input data of the just-removed power_decode test - ppc64_decode_test.cpp: an old standalone decoder test that was never wired into the specification or the build src/instruction keeps test_instruction_profile.C and its instruction_comp component, which remain real tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's now part of the Dyninst integration tests.
dyninst/dyninst#2193