Skip to content

fix config keys dbt silently discards (columns, tag) - #9926

Open
a-monteiro wants to merge 1 commit into
mainfrom
andre/fix-config-deprecations
Open

fix config keys dbt silently discards (columns, tag)#9926
a-monteiro wants to merge 1 commit into
mainfrom
andre/fix-config-deprecations

Conversation

@a-monteiro

@a-monteiro a-monteiro commented Aug 8, 2026

Copy link
Copy Markdown
Member

dbt treats unrecognized keys under config: as custom keys and silently discards them (CustomKeyInConfigDeprecation, D026 — dbt Cloud has been warning about this on every run). A scan across all five subprojects found 8 real occurrences, and they weren't cosmetic: config dbt was throwing away.

Three spine models (chain_swap_trades, dex_solana_bot_trades, dex_evm_bot_trades) had their whole columns: block — including the YAML anchors the per-project sibling models alias — nested under config:, so none of those column descriptions ever made it into the manifest. The block moves to the model level; anchors still precede their aliases, so the siblings are untouched.

Four solana *_bot_users models buried a user column with an intended unique test inside config:. For soul_sniper and alpha_dex that was their only test, so the constraint has never run. The column is now live (and the scalar data_tests: unique shorthand corrected to a list, which is what dbt requires once the key is actually read). This PR's CI runs those four unique tests for the first time — if one fails, the data violates a constraint its author intended, which is worth knowing.

ajna_erc20_pools used singular tag:, so its four tags were never applied; renamed to tags:. None of them is used by any prod/CI selector (those only use prod_exclude, remove, static), so the only effect is a one-time state:modified flag.

@github-actions github-actions Bot added WIP work in progress dbt: dex covers the DEX dbt subproject dbt: solana covers the Solana dbt subproject dbt: daily covers the Daily dbt subproject labels Aug 8, 2026

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@a-monteiro
a-monteiro marked this pull request as ready for review August 8, 2026 14:10
@cursor

cursor Bot commented Aug 8, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
No SQL or model logic changes, but CI will newly run four unique tests on bot user tables that may fail if duplicate users exist in production data.

Overview
Resolves CustomKeyInConfigDeprecation (D026) by fixing YAML where dbt was ignoring real metadata.

Spine trade models (chain_swap_trades, dex_evm_bot_trades, dex_solana_bot_trades) had entire columns: blocks (including YAML anchors sibling models reuse) nested under config:, so column docs never reached the manifest. Those blocks are moved to the model level with the same anchor definitions.

Four Solana *_bot_users models had a user column and unique test under config:; for some models that was the only constraint, so it never ran. Columns/tests are now at model level, with data_tests: unique expressed as a list.

ajna_erc20_pools used invalid tag: instead of tags:, so its four tags were never applied (renamed only; prod selectors do not depend on them).

Reviewed by Cursor Bugbot for commit 13d690d. Configure here.

@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbt: daily covers the Daily dbt subproject dbt: dex covers the DEX dbt subproject dbt: solana covers the Solana dbt subproject ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant