I add NetFx breaking-change guidance skill - #14845
Conversation
KlausLoeffelmann
left a comment
There was a problem hiding this comment.
While I VERY MUCH like the idea of having a "breaking changes" skill, I think the content of this particular one (or this one scenario it covers, rather) is too niche.
And I very much assume, this is probably meant as a starting point, but that introduces another issue, which we need to prevent, FWIW.
For the scenario itself: I'm also not entirely sure which collection editor is being referred to. Is it the collection editor that Visual Studio shows at design time for the out-of-process designer (as opposed to the in-process designer)? If so, I would rather see this issue covered by a dedicated skill that focuses on Control Designer breaking changes when migrating Control Designer [Dialog-based] Type Editors from .NET Framework to .NET.
If it's the Collection Editor we show at runtime, however, that's an extremely niche scenario. We need to set a high bar and be very mindful about what information we bring into the context window as generally relevant and important. FWIW, I don't think a regression of the runtime Collection Editor clears that bar.
But - that's details. I think this topic is important enough to address it; we just need to figure out that the approach still works, when we got 100 issues we want to be taken into account. And one skill file would definitely not do that.
That's why I think we should consider two complementary approaches to handling breaking changes. This is an extremely important area that deserves high priority:
a) Skills. A concise, high-level skill whose purpose is to highlight the major categories of breaking changes, covering only the highest-risk and most commonly encountered issues, while referencing more specialized skills for the details.
b) Analyzers. We can't fill the context window with countless implementation details. Instead, analyzers could surface "Copilot Warnings" that flag potential issues for the agent to review and verify.
Happy to discuss more!
|
|
||
| # WinForms .NET Framework Breaking-Change Guidance | ||
|
|
||
| Use this skill when a task asks for WinForms compatibility differences from |
There was a problem hiding this comment.
The "Use this skill" paragraph should be moved into the front matter description field, but it shouldn't instruct the model to "use this skill explicitly." The description is the metadata that the harness agent uses to determine whether the skill should be loaded into the context window.
|
Thanks for the review. I moved the task-selection wording into the frontmatter description and removed the redundant “Use this skill” paragraph in f8743d8. The tracked example is the design-time Collection Editor used by WinForms designers, not an application runtime editor. I agree that a growing catalog should not become one monolithic skill; I kept the current content scoped while the high-level skill plus specialized guidance/analyzer direction is discussed. Validation: parsed the YAML frontmatter and ran |
Fixes #14770
Proposed changes
netfx-breaking-change-guidancerepository skill.Customer Impact
Regression?
.github/skills.Risk
Test methodology
SKILL.mdblock in Create Skill for NetFx breaking changes #14770.git diff --check.Test environment
Microsoft Reviewers: Open in CodeFlow