-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix The Form1 title bar change to white color when set the RightToLeft to Yes in PropertyGrid control #14742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sathish-087
wants to merge
5
commits into
dotnet:main
Choose a base branch
from
Sathish-087:Fix_Issue_12582
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7f94304
Added fix for this issue 12582
Sathish-087 ecd4c05
Merge branch 'dotnet:main' into Fix_Issue_12582
Sathish-087 b2fc457
Address review changes
Sathish-087 9845759
Added unit test cases
Sathish-087 13446e9
Address review comments
Sathish-087 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider extracting this new DWM call into a small private helper (e.g.
SetFormImmersiveDarkModeInternal(bool isDarkMode)), mirroring the existingSetFormAttributeColorInternal:and call it here:
Benefits:
SetFormTitleProperties()non-unsafe. The only reason this method's signature was changed tounsafeis the&isDarkpointer. Moving that into a dedicated helper (asSetFormAttributeColorInternalalready does with&colorRef) confinesunsafeto the small helper and narrows the unsafe scope of the rest of the method.SetFormAttributeColorInternalcalls, with the guard condition kept in the caller (same pattern as theProperties.TryGetValue(...)checks below)..AssertSuccess(). The adjacentSetFormAttributeColorInternaldeliberately ignores the HRESULT.AssertSuccess()isDebug.Assert(Succeeded, ...), andDWMWA_USE_IMMERSIVE_DARK_MODE(attribute 20) is unsupported on Windows 10 builds < 19041, where the call can return a failure HRESULT and trip a debug assertion. Matching the surrounding "ignore HRESULT" pattern avoids that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion—agreed. I’ll extract the DWM call into a private SetFormImmersiveDarkModeInternal helper (mirroring SetFormAttributeColorInternal), keep SetFormTitleProperties() non-unsafe, and drop .AssertSuccess() so we ignore the HRESULT consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We should take this after those changes.