Skip to content

Implement ClrDataTypeInstance GetName and GetDefinition in cDAC#131366

Open
rcj1 with Copilot wants to merge 5 commits into
mainfrom
copilot/implement-getname-getdefinition
Open

Implement ClrDataTypeInstance GetName and GetDefinition in cDAC#131366
rcj1 with Copilot wants to merge 5 commits into
mainfrom
copilot/implement-getname-getdefinition

Conversation

Copilot AI commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Implements cDAC-native ClrDataTypeInstance name and definition resolution without metadata-cache fallback.

Changes

  • Format names through the managed type-handle path with HRESULT and debug validation.
  • Resolve definitions across arrays, function pointers, parameterized types, and unloaded TypeDefs.
  • Add module, token, and nullable type-handle state to ClrDataTypeDefinition without implementing its APIs.
  • Add cross-architecture coverage for buffer handling and definition resolution.

Copilot AI and others added 3 commits July 25, 2026 04:20
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 25, 2026 04:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI changed the title Implement CLRDataTypeInstance GetName and GetDefinition in cDAC Implement ClrDataTypeInstance GetName and GetDefinition in cDAC Jul 25, 2026
Copilot finished work on behalf of rcj1 July 25, 2026 04:34
Copilot AI requested a review from rcj1 July 25, 2026 04:34
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 25, 2026 06:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 25, 2026 07:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@rcj1
rcj1 marked this pull request as ready for review July 25, 2026 07:08
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants