Skip to content

Add unsafe context migration code fixes #131337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EgorBo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add unsafe context migration code fixes #131337

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a76e1e
Add unsafe context migration code fixes
EgorBo Jul 24, 2026
d86aacc
Address unsafe contract propagation feedback
EgorBo Jul 24, 2026
1201bbc
Address review feedback on unsafe migration code fixes
EgorBo Jul 24, 2026
da45c48
Address PR feedback on unsafe expression parsing and line endings
EgorBo Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,594 changes: 1,594 additions & 0 deletions src/tools/illink/src/ILLink.CodeFix/AddUnsafeContextCodeFixProvider.cs
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/tools/illink/src/ILLink.CodeFix/ILLink.CodeFixProvider.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
</ItemGroup>

<ItemGroup>
<Compile Include="..\ILLink.RoslynAnalyzer\UnsafeContractHelpers.cs" Link="UnsafeContractHelpers.cs" />
<Compile Include="..\ILLink.RoslynAnalyzer\UnsafeMigrationSyntaxHelpers.cs" Link="UnsafeMigrationSyntaxHelpers.cs" />
</ItemGroup>

Expand Down
574 changes: 0 additions & 574 deletions src/tools/illink/src/ILLink.CodeFix/RequiresUnsafeCodeFixProvider.cs
View file
Open in desktop

This file was deleted.

10 changes: 8 additions & 2 deletions src/tools/illink/src/ILLink.CodeFix/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@
<data name="RequiresDynamicCodeCodeFixTitle" xml:space="preserve">
<value>Add RequiresDynamicCode attribute to parent method</value>
</data>
<data name="RequiresUnsafeCodeFixTitle" xml:space="preserve">
<value>Add 'unsafe' to parent method</value>
<data name="AddUnsafeContextCodeFixTitle" xml:space="preserve">
<value>Add unsafe context</value>
</data>
<data name="AddUnsafeToExternCodeFixTitle" xml:space="preserve">
<value>Mark extern member 'unsafe'</value>
Expand All @@ -144,6 +144,12 @@
<data name="AddUnsafeToFieldCodeFixTitle" xml:space="preserve">
<value>Mark field-like member 'unsafe'</value>
</data>
<data name="SynchronizeUnsafeContractCodeFixTitle" xml:space="preserve">
<value>Propagate unsafe contract</value>
</data>
<data name="SynchronizeUnsafeContractDiscardingSafeCodeFixTitle" xml:space="preserve">
<value>Propagate unsafe contract (discards explicit 'safe')</value>
</data>
<data name="UconditionalSuppressMessageCodeFixTitle" xml:space="preserve">
<value>Add UnconditionalSuppressMessage attribute to parent method</value>
</data>
Expand Down
Loading
Loading