Skip to content

Improve CI scanner duplicate KBE detection #131312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svick wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

Improve CI scanner duplicate KBE detection #131312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-failure-scan.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion .github/workflows/ci-failure-scan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,14 @@ If the same signature appears in *every* sampled build (100% failure rate in the
- List builds: `?definitions={id}&branchName=refs/heads/main&statusFilter=completed&resultFilter=succeeded,failed,partiallySucceeded&%24top=25&api-version=7.1`
- Timeline: `/builds/{id}/timeline?api-version=7.1` returns flat `records[]`; reconstruct via `parentId`. A failed record with non-null log id is a leaf to inspect.
- **Helix REST.** `https://helix.dot.net/api/jobs/{jobId}/workitems?api-version=2019-06-17`. Each item has `Name`, `State`, `ExitCode`, `ConsoleOutputUri`. Failed: `ExitCode != 0` or `State == "Failed"`.
- **Build Analysis attachment (best-effort).** `https://dev.azure.com/dnceng-public/public/_apis/build/builds/{id}/attachments/Build_Analysis_KnownIssues_v1?api-version=7.1`. Use to dedupe. 404 = none attached; do not fail.
- **Build Analysis GitHub check (best-effort).** Read the source SHA from the
AzDO build, then query
`GET /repos/dotnet/runtime/commits/{sha}/check-runs` and inspect the completed
`Build Analysis` check's `output.text`. If the report links the source build's
failure to an existing issue, record `existing-kbe #<n>`. Reports omit some
known errors when they exceed GitHub's output limits, so absence is not proof
that Build Analysis did not match; always continue with the exact KBE searches
in Step 4.2 after a miss.
Comment on lines +225 to +229

### Step 3.5 — Follow-up-build presence gate

Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/shared/create-kbe.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ best-match ranking can place noisier hits above the correct one.
`Known Build Error` and area labels, so the label-scoped variations above
skip over it.

When a failure includes a complete test method identifier, search that
identifier verbatim before deriving any shorter stem. Do not truncate
underscore-delimited identifiers (for example, keep
`CreateFileChangeToken_RootDeletedAndRecreated_TokenFiresWhenFileCreated`);
GitHub search does not reliably prefix-match them. Only strip the specific
platform, architecture, and type-width suffixes described in variation 6.

Variations 4 and 5 catch sibling failures filed for the same test class on a
different platform or runtime variant, plus pre-existing area-team trackers
that lack the `Known Build Error` label. Variation 6 catches siblings at
Expand Down
Loading