Skip to content

Don't take the address of a subscripted inline-array field #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Jul 19, 2026
Merged

Don't take the address of a subscripted inline-array field #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.VisitStmt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1530,7 +1530,9 @@ private void VisitImplicitCastExpr(ImplicitCastExpr implicitCastExpr)
// value type, which has no implicit pointer conversion, so take its address to
// bind it to a pointer. A compatible-mode fixed buffer decays on its own, and
// array locals (managed arrays) or string literals must not be addressed here.
if (!Config.GenerateCompatibleCode && (subExpr is MemberExpr) && (subExpr.Type.CanonicalType is ConstantArrayType) && (implicitCastExpr.Type.CanonicalType is PointerType))
// A subscripted field (`arr[i]`) indexes the inline array in place, so the decay
// there is an lvalue that must not be addressed.
if (!Config.GenerateCompatibleCode && (subExpr is MemberExpr) && (subExpr.Type.CanonicalType is ConstantArrayType) && (implicitCastExpr.Type.CanonicalType is PointerType) && !IsPrevContextStmt<ArraySubscriptExpr>(out _, out _))
{
outputBuilder.Write('&');
}
Expand Down
1 change: 1 addition & 0 deletions ...s/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Compatible.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
1 change: 1 addition & 0 deletions ...unctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Compatible.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
1 change: 1 addition & 0 deletions ...ines/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Default.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(&pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
1 change: 1 addition & 0 deletions ...s/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Default.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(&pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
1 change: 1 addition & 0 deletions ...lines/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Latest.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(&pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
1 change: 1 addition & 0 deletions ...es/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Latest.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(&pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
1 change: 1 addition & 0 deletions ...ines/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Preview.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(&pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
1 change: 1 addition & 0 deletions ...s/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.CSharp.Preview.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static unsafe partial class Methods
public static void MyFunction([NativeTypeName("struct MyStruct *")] MyStruct* pStruct)
{
MyOtherFunction(&pStruct->Data);
pStruct->Data[15] = 1;
}
}
}
3 changes: 2 additions & 1 deletion ...nes/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Compatible.Unix.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(pStruct-&gt;Data);</code>
<code>MyOtherFunction(pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
3 changes: 2 additions & 1 deletion .../FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Compatible.Windows.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(pStruct-&gt;Data);</code>
<code>MyOtherFunction(pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
3 changes: 2 additions & 1 deletion ...elines/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Default.Unix.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);</code>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
3 changes: 2 additions & 1 deletion ...nes/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Default.Windows.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);</code>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
3 changes: 2 additions & 1 deletion ...selines/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Latest.Unix.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);</code>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
3 changes: 2 additions & 1 deletion ...ines/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Latest.Windows.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);</code>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
3 changes: 2 additions & 1 deletion ...elines/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Preview.Unix.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);</code>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
3 changes: 2 additions & 1 deletion ...nes/FunctionDeclarationBodyImport/ArrayFieldToPointerArgumentTest.Xml.Preview.Windows.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
<param name="pStruct">
<type>MyStruct*</type>
</param>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);</code>
<code>MyOtherFunction(&amp;pStruct-&gt;Data);
pStruct-&gt;Data[15] = 1;</code>
</function>
</class>
</namespace>
Expand Down
1 change: 1 addition & 0 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/Baseline/FunctionDeclarationBodyImportTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ struct MyStruct
void MyFunction(struct MyStruct* pStruct)
{
MyOtherFunction(pStruct->Data);
pStruct->Data[15] = 1;
}
";

Expand Down
Loading