Change github actions filter pattern - #11355
Merged
Merged
Conversation
Author
|
@amaltaro Can you try with this change? It worked on my fork. |
|
Jenkins results:
|
amaltaro
approved these changes
Oct 31, 2022
amaltaro
left a comment
amaltaro
left a comment
Contributor
There was a problem hiding this comment.
Thank, Kenyi.
I found different places mentioning syntaxes like: '*.*.*' vs *.*.*, but if you tested it, let's give it a try then.
Contributor
|
@khurtado Kenyi, I still see a bunch of GH actions with an error message as "Startup failure". I guess it shouldn't even start to run it if the filter expression doesn't match the tag, right? Could you please have another look into this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11336
Status
ready
Description
This filter follows the filter patterns from:
(https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet)
It should match to the production tags in the form of X.Y.Z.something or just X.Y.Z
JENKINS tags do not follow this pattern and will be excluded.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
Overwrites the changes in:
#11337
Since for some reason, JENKINS tags were still triggered with this one in the main repository (yet not on my tests on my fork)
External dependencies / deployment changes
GH actions