Split microservices into separate packages - #11324
Merged
Merged
Conversation
|
Jenkins results:
|
|
Jenkins results:
|
goughes
force-pushed
the
split-ms-pypi
branch
3 times, most recently
from
October 6, 2022 19:06
2b7a3f4 to
01bf2a3
Compare
|
Jenkins results:
|
amaltaro
reviewed
Oct 6, 2022
amaltaro
left a comment
amaltaro
left a comment
Contributor
There was a problem hiding this comment.
Thanks Erik, changes look good to me. I left one comment along the code though.
I think we should stop building reqmgr2ms for PyPi, even though we still need it for RPMs.
| TOBUILD=$1 | ||
| # list of packages that can be built and uploaded to pypi | ||
| PACKAGES="wmagent wmagent-devtools wmcore reqmon reqmgr2 reqmgr2ms global-workqueue acdcserver" | ||
| PACKAGES="wmagent wmagent-devtools wmcore reqmon reqmgr2 reqmgr2ms global-workqueue acdcserver |
Contributor
There was a problem hiding this comment.
Perhaps we should stop building/uploading reqmgr2ms to PyPi?
|
Jenkins results:
|
|
Jenkins results:
|
Contributor
Author
|
Thanks @amaltaro, I have removed reqmgr2ms from requirements.txt and the PyPI build script. |
|
Jenkins results:
|
|
Jenkins results:
|
amaltaro
self-requested a review
October 6, 2022 20:44
amaltaro
approved these changes
Oct 6, 2022
amaltaro
left a comment
amaltaro
left a comment
Contributor
There was a problem hiding this comment.
Thanks Erik, this looks good to go!
Contributor
|
Thanks Erik! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10159
Status
Not tested
Description
This PR updates
build_dependencies.py, creates a new reqmgr2ms-core system and adds separate packages for all the current microservices.Is it backward compatible (if not, which system it affects?)
Yes, we leave the current
reqmgr2mspackage which is still used for RPM based builds.Related PRs
Follow up to #10357 as I have created a "MSCore" directory and moved MSCore, MSManager and TaskManager modules to it.
External dependencies / deployment changes
We will need to update each microservice's config.py since the path for MSManager has changed.
https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/168
https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/167
https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/166
dmwm/deployment#1192