Fix Issue #23356 - ImportC: The preprocessor is improperly invoked, on macOS, when cross-compiling.#23357
Open
just-harry wants to merge 1 commit into
Open
Conversation
…ed, on macOS, when cross-compiling.
just-harry
force-pushed
the
fix-macos-cross-compilation-preprocessor
branch
from
5a21394 to
bb2bafa
Compare
Contributor
|
This is a bit too simplistic - you don't want to run the Apple host clang as preprocessor either, but some proper cross-compiler with the right headers and predefines for the cross-compilation target (or a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DMD is run on macOS, the preprocessor is expected to be clang instead of GCC, and clang requires a different command-line than GCC does to solely preprocess a file without compiling and linking it.
DMD currently uses the clang-logic when the target is macOS--this is the wrong way 'round: the clang-logic should be used when the host is macOS.