Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

Change the way schema ids are generated - #1

Merged
etaque merged 5 commits into
dividat:masterfrom
etaque:fix-list-ids
Apr 4, 2018
Merged

Change the way schema ids are generated#1
etaque merged 5 commits into
dividat:masterfrom
etaque:fix-list-ids

Conversation

@etaque

@etaque etaque commented Apr 4, 2018 •
edited
Loading

Copy link
Copy Markdown
  • Allow the use of lists at a top level by adding type args in ids.
  • Hide canonical names in ids to avoid exposing app internals.
  • bumped a few deps

andrew-domino and others added 5 commits March 5, 2018 12:01
@andrew-domino
Update libraries and sbt to latest
8cd0591 
This brings docless up to:
  - cats 1.x
  - circe 0.9
  - sbt 1.1.x

Fixes timeoutdigital#16
@andrew-domino
Update travisci builds
c9fe78c
@andrew-domino
Only depend on 2.11.x that all libs support
d041984
@etaque
Use type args in JsonSchema ids to avoid id collision for lists
f8928c6 
Without this, lists as JsonSchema instances do share the same id, `scala.collection.immutable.List`
This also further upgrade dependencies.
@etaque
Use short version of type names to avoid exposing internals.
24c359d
@etaque
etaque merged commit 09ad51d into dividat:master Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@etaque @andrew-domino