Replace wai-session with dedicated forked packages - #2582
Merged
Conversation
Switch from patched upstream packages to dedicated forks: - wai-session -> wai-session-maybe (Network.Wai.Session.Maybe) - wai-session-clientsession -> wai-session-clientsession-deferred (Network.Wai.Session.ClientSession.Deferred) The upstream packages are unmaintained (last releases 2018/2012) and IHP's patches change the SessionStore type in a backwards-incompatible way (IO ByteString -> IO (Maybe ByteString)). Publishing as separate packages avoids carrying Nix overlay patches and allows coexistence with the original packages in dependency trees. Repos: - https://github.com/digitallyinduced/wai-session-maybe - https://github.com/digitallyinduced/wai-session-clientsession-deferred Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Core Size & Compile Allocations Benchmark
HTTP Latency (GET /, 200 runs)
Top 10 modules (this PR)
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wai-session(last release 2018) withwai-session-maybe— moduleNetwork.Wai.Session.Maybewai-session-clientsession(last release 2012) withwai-session-clientsession-deferred— moduleNetwork.Wai.Session.ClientSession.DeferredThe upstream packages are unmaintained and IHP's patches change the
SessionStoretype in a backwards-incompatible way (IO ByteString→IO (Maybe ByteString)). Publishing as separate packages with distinct module names avoids carrying Nix patches and allows coexistence with the original packages in dependency trees.Test plan
ghcitype check passes (105 modules loaded)nix flake check --impure)🤖 Generated with Claude Code