feat(pdfkit): use fflate instead of zlib in the browser build - #3485
Merged
Conversation
Applies upstream pdfkit PR #1760. The browser build no longer imports Node's zlib, so consumers don't need a bundler polyfill for it, and browserify-zlib and pako are gone from the dependency tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5489b94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies foliojs/pdfkit#1760 to our fork. The browser build no longer imports Node's
zlib, so consumers don't need a bundler polyfill for it, andbrowserify-zlibandpako(plus their alias workarounds in the rollup config) are gone from the dependency tree.Both
deflateSynccall sites now go throughsrc/zlib.js, which picks fflate'szlibSyncor nativezliboff theBROWSERconstant, so each bundle keeps only one compressor after tree-shaking — verified in the built output. fflate returns a plainUint8Array, which the bundledBufferpolyfill'sconcatrejects, so the browser branch wraps it inBuffer.from;PDFDocument._writealso takes upstream'sinstanceof Uint8Arraycheck.Tests: the existing PNG test now flips
BROWSERwithvi.stubGlobalinstead of mocking thezlibmodule (which needed a vitest setup file definingBROWSERfor the package). Full suite passes, and the browser bundle was checked end to end by rendering text plus an interlaced PNG.🤖 Generated with Claude Code