Skip to content

fix(render): specify the left coordinate in named destinations so internal links navigate in macOS Preview #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benbowler wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −1
Open

fix(render): specify the left coordinate in named destinations so internal links navigate in macOS Preview #3460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/named-destination-left-coordinate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@react-pdf/render': patch
---

fix(render): specify the left coordinate in named destinations so internal links navigate in macOS Preview
2 changes: 1 addition & 1 deletion packages/render/src/operations/setDestination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const setDestination = (ctx: Context, node: SafeNode) => {
if (!node.props) return;

if ('id' in node.props) {
ctx.addNamedDestination(node.props.id!, 'XYZ', null, node.box.top, null);
ctx.addNamedDestination(node.props.id!, 'XYZ', node.box.left ?? 0, node.box.top, null);
}
};

Expand Down
14 changes: 14 additions & 0 deletions packages/render/tests/operations/setDestination.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@ describe('operations setDestination', () => {

expect(ctx.addNamedDestination.mock.calls).toHaveLength(1);
expect(ctx.addNamedDestination.mock.calls[0][0]).toBe('test');
expect(ctx.addNamedDestination.mock.calls[0][2]).toBe(0);
expect(ctx.addNamedDestination.mock.calls[0][3]).toBe(20);
});

test('should pass the node left coordinate as the destination left', () => {
const ctx = createCTX();
const box = { top: 20, left: 15 };
const props = { id: 'test' };
const doc = { type: P.View, style: {}, props, box } as SafeNode;

setDestination(ctx, doc);

expect(ctx.addNamedDestination.mock.calls).toHaveLength(1);
expect(ctx.addNamedDestination.mock.calls[0][2]).toBe(15);
expect(ctx.addNamedDestination.mock.calls[0][3]).toBe(20);
});

Expand Down