fix: clamp extreme number values to valid PDF range - #3337
Open
cyphercodes wants to merge 2 commits into
Open
Conversation
Fixes diegomura#3277 - Error: unsupported number when rendering PDFs with extreme glyph positioning values. The number() function in both renderGlyphs.ts and object.js would throw an error when values exceeded the PDF-valid range of -1e21 to 1e21. This occurred when calculating glyph advance positions with certain font/text combinations. Instead of throwing, we now clamp values to the valid range, which allows PDF generation to continue while maintaining valid output.
🦋 Changeset detectedLatest commit: 8d7fe98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the fix. |
Author
|
Added the missing changeset for this bugfix:
Local verification:
Note: GitHub Actions is still waiting on maintainer approval for the forked PR run ( |
diegomura
reviewed
Aug 8, 2026
Comment on lines
+119
to
+121
| // Clamp to valid PDF number range to prevent errors with extreme values | ||
| const clamped = Math.max(-1e21 + 1, Math.min(1e21 - 1, n)); | ||
| return Math.round(clamped * 1e6) / 1e6; |
Owner
There was a problem hiding this comment.
won't this mean that rendering will be broken? In the sense that it won't show things as they should
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3277
The number() function would throw an error when values exceeded the PDF-valid range of -1e21 to 1e21. This occurred when calculating glyph advance positions with certain font/text combinations.
Instead of throwing, we now clamp values to the valid range, allowing PDF generation to continue while maintaining valid output.
Changes