Skip to content

chore: Enforce that stored versions match their keys - #11136

Open
Bownairo wants to merge 1 commit into
masterfrom
eero/hostos-version-invariant
Open

chore: Enforce that stored versions match their keys#11136
Bownairo wants to merge 1 commit into
masterfrom
eero/hostos-version-invariant

Conversation

@Bownairo

@Bownairo Bownairo commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Following the invariant added in #10942, add an invariant for HostOS versions, too.

@github-actions github-actions Bot added the chore label Aug 13, 2026
@Bownairo
Bownairo marked this pull request as ready for review August 13, 2026 19:42
@Bownairo
Bownairo requested a review from a team as a code owner August 13, 2026 19:42

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@zeropath-ai

zeropath-ai Bot commented Aug 13, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 725e512.

Security Overview
Detected Code Changes
Change Type Relevant files
Bug Fix ► rs/registry/canister/src/invariants/hostos_version.rs
      Fix function signatures and assertion to ensure version key consistency
► rs/registry/canister/unreleased_changelog.md
      Add changelog entry for enforcing hostos_version_id consistency

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test? Let's see this trip wire explode 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants