test(ledger-suite-orchestrator): drop the StateMachine test fixture

[gregorydemay]

📚 PR stack

1. test(ledger-suite-orchestrator): migrate integration tests to PocketIC #10949 — merged
2. test(cketh): deduplicate signed-transaction and transaction-hash literals in integration tests #10950 — merged
3. test(cketh): migrate integration tests to PocketIC #10955 — test(cketh): migrate integration tests to PocketIC
4. this PR — test(ledger-suite-orchestrator): drop the StateMachine test fixture 👈 you are here

Summary

Completes the DEFI-2262 PocketIC migration for rs/ethereum: with the ckETH minter's integration tests running on PocketIC, nothing in rs/ethereum still uses the ledger-suite-orchestrator's StateMachine-based test fixture. This deletes it, along with the now-unused ic-state-machine-tests, ic-types, ic-management-canister-types-private and assert_matches dependencies, leaving PocketIC as the orchestrator's sole test harness.

• Removes the StateMachine-based LedgerSuiteOrchestrator/flow/universal_canister fixture from ledger-suite-orchestrator/test_utils; the pocket_ic module is now the crate's only fixture.
• Keeps the environment-agnostic helpers that the pocket_ic module and cketh still import at their existing paths (wasm loaders, init-arg builders, usdc()/usdt(), constants).

This replaces #10956. That PR was auto-closed as merged when its content briefly reached its base branch by mistake; the content here is identical, reapplied on top of #10955 so the two changes stay reviewable separately.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Removes the now-unused StateMachine-based integration-test fixture from ledger-suite-orchestrator/test_utils, completing the PocketIC migration in rs/ethereum and leaving PocketIC as the sole test harness for the orchestrator’s integration tests.

Changes:

• Deleted the StateMachine fixture modules (flow, universal_canister) and the StateMachine-based LedgerSuiteOrchestrator/helpers from the test-utils crate.
• Kept environment-agnostic helpers (wasm loaders, init-arg builders, token helpers/constants) at their existing paths while retaining the PocketIC fixture module.
• Dropped StateMachine-related dependencies from Cargo.toml/BUILD.bazel and updated Cargo.lock accordingly.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
rs/ethereum/ledger-suite-orchestrator/test_utils/src/universal_canister.rs	Removed StateMachine-only universal canister helper.
rs/ethereum/ledger-suite-orchestrator/test_utils/src/lib.rs	Removed StateMachine fixture exports/impls; kept shared helpers and PocketIC module.
rs/ethereum/ledger-suite-orchestrator/test_utils/src/flow.rs	Removed StateMachine-only flow/assertion helpers.
rs/ethereum/ledger-suite-orchestrator/test_utils/Cargo.toml	Pruned StateMachine-related dependencies from the test-utils crate.
rs/ethereum/ledger-suite-orchestrator/test_utils/BUILD.bazel	Pruned StateMachine-related Bazel deps for the test-utils crate.
Cargo.lock	Updated lockfile to reflect removed dependencies.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[gregorydemay]

🤖 Closing: not needed. #10956 was wrongly marked merged, and since that cannot be undone its content stays where it landed, in #10955. This PR would have re-applied the same deletion on top of it.

The revert I had pushed to #10955 to make room for this PR has itself been reverted (c7bf937b36), so #10955 again carries the ledger-suite-orchestrator fixture deletion exactly as #10956 had it.