Skip to content

refactor: Remove ReplicaVersion::default() #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frankdavid wants to merge 12 commits into
base: master
Choose a base branch
from
Open

refactor: Remove ReplicaVersion::default() #11087

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
71b8018
refactor: Remove ReplicaVersion::default()
frankdavid Aug 10, 2026
43bc786
Fixes
frankdavid Aug 10, 2026
6e34d3c
build
frankdavid Aug 10, 2026
2aeeb4f
Merge remote-tracking branch 'origin/master' into frankdavid/explicit…
frankdavid Aug 13, 2026
fd6c956
fixup DependenciesBuilder
frankdavid Aug 13, 2026
2041896
fixes
frankdavid Aug 14, 2026
3fa4d20
Merge remote-tracking branch 'origin/master' into frankdavid/explicit…
frankdavid Aug 14, 2026
659fbd9
fix after merge
frankdavid Aug 14, 2026
cab44d6
serialization
frankdavid Aug 14, 2026
88596a6
deserialize_arc_str
frankdavid Aug 14, 2026
04fb96c
Automatically fixing code for linting and formatting issues
Aug 14, 2026
898faad
cafebabe0000ffff0000ffff0000ffff0000ffff
frankdavid Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion rs/artifact_pool/benches/load_blocks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use ic_interfaces::time_source::SysTimeSource;
use ic_logger::replica_logger::no_op_logger;
use ic_test_utilities_consensus::{fake::*, make_genesis};
use ic_test_utilities_types::{
ids::{node_test_id, subnet_test_id},
ids::{node_test_id, subnet_test_id, test_replica_version},
messages::SignedIngressBuilder,
};
use ic_types::consensus::dkg::{DkgDataPayload, DkgSummary};
Expand All @@ -36,6 +36,7 @@ where
let mut consensus_pool = ConsensusPoolImpl::new(
node_test_id(0),
subnet_test_id(0),
test_replica_version(),
make_genesis(DkgSummary::fake()).into(),
pool_config,
ic_metrics::MetricsRegistry::new(),
Expand Down Expand Up @@ -158,6 +159,7 @@ fn add_validated_block(criterion: &mut Criterion) {
let mut pool = ConsensusPoolImpl::new(
node_test_id(0),
subnet_test_id(0),
test_replica_version(),
make_genesis(DkgSummary::fake()).into(),
pool_config.clone(),
ic_metrics::MetricsRegistry::new(),
Expand Down
10 changes: 8 additions & 2 deletions rs/artifact_pool/src/backup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ impl BackupArtifact {
mod tests {
use super::*;
use ic_test_utilities_consensus::fake::*;
use ic_test_utilities_types::ids::node_test_id;
use ic_test_utilities_types::ids::{node_test_id, test_replica_version};
use ic_types::{
RegistryVersion,
batch::*,
Expand All @@ -643,7 +643,10 @@ mod tests {

#[test]
fn test_random_tape_conversion() {
let artifact = RandomTape::fake(RandomTapeContent::new(Height::from(22)));
let artifact = RandomTape::fake(RandomTapeContent::new(
Height::from(22),
test_replica_version(),
));
let mut buf = Vec::new();
pb::RandomTape::from(artifact.clone())
.encode(&mut buf)
Expand All @@ -659,6 +662,7 @@ mod tests {
let artifact = Finalization::fake(FinalizationContent::new(
Height::from(22),
CryptoHashOf::from(CryptoHash(vec![1, 2, 3])),
test_replica_version(),
));
let mut buf = Vec::new();
pb::Finalization::from(artifact.clone())
Expand All @@ -675,6 +679,7 @@ mod tests {
let artifact = Notarization::fake(NotarizationContent::new(
Height::from(22),
CryptoHashOf::from(CryptoHash(vec![1, 2, 3])),
test_replica_version(),
));
let mut buf = Vec::new();
pb::Notarization::from(artifact.clone())
Expand Down Expand Up @@ -702,6 +707,7 @@ mod tests {
certified_height: Height::from(42),
time: UNIX_EPOCH,
},
test_replica_version(),
),
node_test_id(333),
);
Expand Down
4 changes: 2 additions & 2 deletions rs/artifact_pool/src/canister_http_pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ mod tests {
content_hash: CryptoHashOf::from(CryptoHash(vec![1, 2, 3])),
content_size: 42,
is_reject: false,
replica_version: ReplicaVersion::default(),
replica_version: ic_test_utilities_types::ids::test_replica_version(),
},
payment_receipt: CanisterHttpPaymentReceipt::default(),
},
Expand All @@ -330,7 +330,7 @@ mod tests {
content_hash: ic_types::crypto::crypto_hash(response),
content_size: 42,
is_reject: false,
replica_version: ReplicaVersion::default(),
replica_version: ic_test_utilities_types::ids::test_replica_version(),
},
payment_receipt: CanisterHttpPaymentReceipt::default(),
},
Expand Down
Loading
Loading