Skip to content

test(ledger-suite-orchestrator): migrate integration tests to PocketIC #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregorydemay merged 7 commits into from
Aug 12, 2026
Merged

test(ledger-suite-orchestrator): migrate integration tests to PocketIC #10949

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f0b25b7
test(ledger-suite-orchestrator): migrate integration tests to PocketIC
gregorydemay Jul 29, 2026
223a448
refactor(ledger-suite-orchestrator): drop dead AsRef<PocketIc> impls
gregorydemay Jul 29, 2026
759c646
style(ledger-suite-orchestrator): consolidate imports for consistency
gregorydemay Jul 29, 2026
d0af1f4
refactor(ledger-suite-orchestrator): drop redundant clone on module_hash
gregorydemay Jul 29, 2026
52b82fe
docs(ledger-suite-orchestrator): drop stale StateMachine timing comment
gregorydemay Jul 29, 2026
de18dda
build(ledger-suite-orchestrator): drop duplicate pocket-ic-server dep
gregorydemay Jul 29, 2026
e0c6621
refactor(ledger-suite-orchestrator): upgrade canisters through PocketIc
gregorydemay Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions rs/ethereum/ledger-suite-orchestrator/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ rust_ic_test(
data = [
"ledger_suite_orchestrator_canister.wasm.gz",
"ledger_suite_orchestrator_canister_getblocksdisabled.wasm.gz",
"//:pocket-ic-server",
Comment thread
gregorydemay marked this conversation as resolved.
"//rs/ledger_suite/icrc1/archive:archive_canister_u256.wasm.gz",
"//rs/ledger_suite/icrc1/index-ng:index_ng_canister_u256.wasm.gz",
"//rs/ledger_suite/icrc1/ledger:ledger_canister_u256.wasm.gz",
Expand All @@ -157,22 +158,24 @@ rust_ic_test(
"LEDGER_CANISTER_GET_BLOCKS_DISABLED_WASM_PATH": "$(rootpath //rs/ledger_suite/icrc1/ledger:ledger_canister_u256_getblocksdisabled.wasm.gz)",
"INDEX_CANISTER_WASM_PATH": "$(rootpath //rs/ledger_suite/icrc1/index-ng:index_ng_canister_u256.wasm.gz)",
"LEDGER_ARCHIVE_NODE_CANISTER_WASM_PATH": "$(rootpath //rs/ledger_suite/icrc1/archive:archive_canister_u256.wasm.gz)",
"POCKET_IC_BIN": "$(rootpath //:pocket-ic-server)",
"UNIVERSAL_CANISTER_WASM_PATH": "$(rootpath //rs/universal_canister/impl:universal_canister.wasm.gz)",
},
proc_macro_deps = [],
deps = [
# Keep sorted.
":ledger_suite_orchestrator",
"//:pocket-ic-server",
"//packages/ic-http-types",
"//packages/icrc-ledger-types:icrc_ledger_types_storable",
"//packages/pocket-ic",
"//rs/crypto/test_utils/reproducible_rng",
"//rs/ethereum/ledger-suite-orchestrator/test_utils",
"//rs/ledger_suite/icrc1/ledger",
"//rs/state_machine_tests",
"//rs/types/base_types",
"//rs/types/management_canister_types",
"@crate_index//:assert_matches",
"@crate_index//:candid",
"@crate_index//:ic-management-canister-types",
"@crate_index//:proptest",
],
)
2 changes: 1 addition & 1 deletion rs/ethereum/ledger-suite-orchestrator/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ assert_matches = { workspace = true }
candid_parser = { workspace = true }
ic-crypto-test-utils-reproducible-rng = { path = "../../crypto/test_utils/reproducible_rng" }
ic-ledger-suite-orchestrator-test-utils = { path = "test_utils" }
ic-state-machine-tests = { path = "../../state_machine_tests" }
maplit = { workspace = true }
mockall = { workspace = true }
paste = { workspace = true }
pocket-ic = { path = "../../../packages/pocket-ic" }
proptest = { workspace = true }
scraper = { workspace = true }
tokio = { workspace = true }
3 changes: 2 additions & 1 deletion rs/ethereum/ledger-suite-orchestrator/test_utils/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ rust_library(
deps = [
# Keep sorted.
"//packages/ic-http-types",
"//packages/ic-metrics-assert",
"//packages/ic-metrics-assert:ic-metrics-assert_pocket_ic",
"//packages/icrc-ledger-types:icrc_ledger_types_storable",
"//packages/pocket-ic",
"//rs/ethereum/ledger-suite-orchestrator:ledger_suite_orchestrator",
"//rs/ledger_suite/icrc1/ledger",
"//rs/state_machine_tests",
Expand Down
3 changes: 2 additions & 1 deletion rs/ethereum/ledger-suite-orchestrator/test_utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,13 @@ ic-icrc1-ledger = { path = "../../../ledger_suite/icrc1/ledger" }
ic-ledger-suite-orchestrator = { path = "../../ledger-suite-orchestrator" }
ic-management-canister-types = { workspace = true }
ic-management-canister-types-private = { path = "../../../types/management_canister_types" }
ic-metrics-assert = { path = "../../../../packages/ic-metrics-assert" }
ic-metrics-assert = { path = "../../../../packages/ic-metrics-assert", features = ["pocket_ic"] }
ic-state-machine-tests = { path = "../../../state_machine_tests" }
ic-test-utilities-load-wasm = { path = "../../../test_utilities/load_wasm" }
ic-types-cycles = { path = "../../../types/cycles" }
ic-types = { path = "../../../types/types" }
ic-universal-canister = { path = "../../../universal_canister/lib" }
icrc-ledger-types = { path = "../../../../packages/icrc-ledger-types" }
paste = { workspace = true }
pocket-ic = { path = "../../../../packages/pocket-ic" }
proptest = { workspace = true }
1 change: 1 addition & 0 deletions rs/ethereum/ledger-suite-orchestrator/test_utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ pub use icrc_ledger_types::icrc1::account::Account as LedgerAccount;
use std::sync::Arc;

pub mod flow;
pub mod pocket_ic;
pub mod universal_canister;

const MAX_TICKS: usize = 10;
Expand Down
Loading
Loading