fix: bind redirection token to device AMT GUID#1133
Open
madhavilosetty-intel wants to merge 1 commit into
Open
fix: bind redirection token to device AMT GUID#1133madhavilosetty-intel wants to merge 1 commit into
madhavilosetty-intel wants to merge 1 commit into
Conversation
madhavilosetty-intel
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
+ Coverage 43.59% 43.67% +0.07%
==========================================
Files 143 143
Lines 13621 13633 +12
==========================================
+ Hits 5938 5954 +16
+ Misses 7118 7112 -6
- Partials 565 567 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
madhavilosetty-intel
force-pushed
the
fix/redirection-token-device-binding
branch
from
f161f83 to
fc519c3
Compare
The redirection JWT carried no device claim and the KVM/SOL/IDER WebSocket validated only the signature and expiry, so any valid token (including the login token) could open a session to any device. Mint the redirection token with a deviceId claim set to the device's AMT GUID, and reject the WebSocket unless the token's deviceId is present and matches the host query param. A login token (no deviceId) and a token minted for another device are now rejected.
madhavilosetty-intel
force-pushed
the
fix/redirection-token-device-binding
branch
from
fc519c3 to
80eee0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redirection JWT carried no device claim and the KVM/SOL/IDER WebSocket validated only the signature and expiry, so any valid token (including the login token) could open a session to any device.
Mint the redirection token with a deviceId claim set to the device's AMT GUID, and reject the WebSocket unless the token's deviceId is present and matches the host query param. A login token (no deviceId) and a token minted for another device are now rejected.