fix(hub-ui): preserve toast background on hover - #316
Open
dvcolomban wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the hub UI toast hover styling so the toast’s “glass” background isn’t replaced on hover, aligning hover feedback with the toast content rather than the container.
Changes:
- Removes the hover background class from the toast container.
- Adds hover background styling to the
MessageItemcontent area instead.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dvcolomban
marked this pull request as draft
August 28, 2026 12:15
dvcolomban
force-pushed
the
codex/fix-toast-hover
branch
from
August 28, 2026 12:51
9f5c311 to
f579287
Compare
dvcolomban
marked this pull request as ready for review
August 28, 2026 13:21
dvcolomban
force-pushed
the
codex/fix-toast-hover
branch
from
August 28, 2026 13:47
f579287 to
31d5a75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg-dock-glassmaterial at rest through abg-toast-glassshortcutBefore / after
Both screenshots show the upstream
messages-toastoverlay--with-actionStorybook story in dark mode while hovered.hover:bg-activereplaces the dark glass surface with a lightly tinted transparent background.Theme regression check
These screenshots show the upstream
messages-toastoverlay--stackstory with the pointer over the first toast. The toast uses the same resting material as the dock in each theme.rgba(255, 255, 255, 0.78)rgba(17, 17, 17, 0.9)Validation
pnpm --filter @devframes/hub-ui buildpnpm --filter @devframes/hub-ui typecheckpnpm exec eslint packages/hub-ui/uno.config.ts packages/hub-ui/src/client/components/display/ToastOverlay.vuepnpm exec vitest run packages/hub-ui/src(32 passed)rgba(255, 255, 255, 0.65)torgba(255, 255, 255, 0.78)rgba(17, 17, 17, 0.8)torgba(17, 17, 17, 0.9)