feat(hub-ui): reopen a group's last-opened member ahead of defaultChildId - #309
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Group docks now remember the member last opened in them, per tab. Activating a group reopens that member directly — taking precedence over the group's
defaultChildId— instead of showing the member popover again.For a group A with members B C D and no
defaultChildId: the first click on A reveals the member popover; picking D opens it and records it. Toggling A closes the panel, and the next click reopens D straight away. When adefaultChildIdis set, it seeds the first activation and the last-opened member wins from then on.How
DockSessionStoragegainsgroupLastChildIds(group id → member id), persisted besideselectedDockId/recentDockIdin the per-tabdevframes-dock-sessionstore, so the memory survives reloads without two tabs fighting over it.switchEntryrecords every grouped-member selection (popover, group sidebar, command palette, RPC activation all funnel through it) and resolves a group activation through the newresolveGroupPreferredChild— last-opened member first, thendefaultChildId, each under the existingwhen/visibilityrules, then the first member.whenclause fails) falls back todefaultChildIdgracefully.Covered by new unit tests for
resolveGroupPreferredChildand acreateDocksContextround-trip test; docs and story descriptions updated.Created with the help of an agent.