feat(docs): move color mode toggle to navbar top right - #307
Merged
Conversation
Shadows comark-docs' AppHeader to add a UColorModeButton next to the version history button in the persistent header, so it's reachable at all breakpoints instead of only inside the mobile drawer's body slot.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shadows comark-docs'
AppHeadercomponent to add aUColorModeButtonnextto the version history button in the persistent header's
#rightslot, sothe toggle is reachable at all breakpoints instead of only inside the
mobile drawer's
#bodyslot (which is now redundant, since that same#rightcontent re-renders inside the mobile menu's own header).Files
docs/app/components/AppHeader.vue(new): a Nuxt layer override ofcomark-docs'AppHeader.vue, following the same shadowing conventionalready used by
docs/app/components/AppHeaderBrand.vue.🤖 Generated with the help of an agent