-
Notifications
You must be signed in to change notification settings - Fork 16
feat(hub): expose panel state through client context #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dvcolomban
wants to merge
11
commits into
devframes:main
Choose a base branch
from
dvcolomban:codex/feat-panel-session-lifecycle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
25ed700
feat(hub): expose panel session lifecycle events
dvcolomban ebdbcf6
docs(hub-ui): explain dock restore trust gate
dvcolomban a5d5eb5
fix(hub): align dock panel state event name
dvcolomban 2ffa480
feat(hub): report extensible panel state
dvcolomban 63e7a4a
refactor(hub): clarify panel state snapshots
dvcolomban ae88cf6
chore(examples): log dock panel state updates
dvcolomban 52e8074
fix(examples): log embedded panel state updates
dvcolomban d9b0573
fix(hub): normalize dock panel selection
dvcolomban a5ed1aa
refactor(hub): emit panel state from client context
dvcolomban db3a5a3
refactor(hub): simplify panel state tracking
dvcolomban 7df3648
fix(hub): address panel state review feedback
dvcolomban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { afterEach, describe, expect, it, vi } from 'vitest' | ||
| import { HUB_UI_HIDE_EVENT } from '../constants' | ||
| import { setupEmbeddedVisibility } from './visibility' | ||
|
|
||
| afterEach(() => { | ||
| vi.unstubAllGlobals() | ||
| }) | ||
|
|
||
| describe('setupEmbeddedVisibility', () => { | ||
| it('handles the initial hidden state and later reveal and conceal transitions', () => { | ||
| expect.assertions(5) | ||
|
|
||
| const listeners = new Map<string, EventListener>() | ||
| vi.stubGlobal('window', { | ||
| addEventListener: vi.fn((type: string, listener: EventListener) => { | ||
| listeners.set(type, listener) | ||
| }), | ||
| }) | ||
| const show = vi.fn() | ||
| const hide = vi.fn() | ||
|
|
||
| setupEmbeddedVisibility('hidden', 'Devframe', { show, hide }) | ||
|
|
||
| expect(hide).toHaveBeenCalledOnce() | ||
| expect(show).not.toHaveBeenCalled() | ||
|
|
||
| const preventDefault = vi.fn() | ||
| listeners.get('keydown')!({ | ||
| shiftKey: true, | ||
| altKey: true, | ||
| ctrlKey: false, | ||
| metaKey: false, | ||
| code: 'KeyD', | ||
| preventDefault, | ||
| } as unknown as KeyboardEvent) | ||
| expect(preventDefault).toHaveBeenCalledOnce() | ||
| expect(show).toHaveBeenCalledOnce() | ||
|
|
||
| listeners.get(HUB_UI_HIDE_EVENT)!({} as Event) | ||
| expect(hide).toHaveBeenCalledTimes(2) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.