Refactor AWS CLI installation script#1690
Conversation
Refactor package installation for different Linux distributions and clean up the script. Added support for Alpine and RedHat package managers.
|
@microsoft-github-policy-service agree |
Kaniska244
left a comment
There was a problem hiding this comment.
Hi @faangbait
The tests are failing as VERSION variable got overwritten because of sourcing of /etc/os-release file here. Would you kindly look into it.
Kaniska244
left a comment
There was a problem hiding this comment.
Hi @faangbait
Thank you for the correction. Could you please also bump the feature version.
|
Sorry, I'm out of usage credits. If you need internal documentation, that's your problem per @microsoft-github-policy-service agree |
Well its not merely for internal documentation. Without the version bump this change you are doing, won't be pushed to GHCR. Therefore it can't accepted without the version bump. |
Refactor package installation for different Linux distributions and clean up the script. Added support for Alpine and RedHat package managers.
All of the package installation code + OS detection was ripped straight from common-utils.
features/src/common-utils/main.sh
Lines 389 to 423 in 765e8eb
features/src/common-utils/main.sh
Line 28 in 765e8eb
features/src/common-utils/main.sh
Line 172 in 765e8eb
features/src/common-utils/main.sh
Line 289 in 765e8eb