peer: Limit peer queued output bytes. - #3747
Open
jholdstock wants to merge 1 commit into
Open
Conversation
jholdstock
marked this pull request as draft
July 25, 2026 13:42
Track the total serialized bytes currently queued for sending to each peer, and disconnect a peer whose queued bytes exceed maxQueuedOutputBytes (40 MiB). This limit comfortably exceeds the largest single message.
jholdstock
force-pushed
the
slowread-oom-fix
branch
from
August 4, 2026 02:57
f4bb6aa to
5f9dfd9
Compare
jholdstock
changed the title
jholdstock
marked this pull request as ready for review
August 4, 2026 02:59
Member
Author
|
I've rebased this and its ready for a review, however I'm not sure if it is still needed or desirable after we have already implemented the read deadline in #3751. I am fairly certain the code in this PR works well, but its feels inelegant and brittle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track the total serialized bytes currently queued for sending to each peer, and disconnect a peer whose queued bytes exceed maxQueuedOutputBytes (40 MiB). This limit comfortably exceeds the largest single message.
Note for review
The 40 MiB limit added in this PR has been set somewhat arbitrarily and is worth scrutiny.