Skip to content

Changes to allow MSWin32 to PASS - #9

Open
alabamapaul wants to merge 2 commits into
dbsrgits:masterfrom
alabamapaul:master
Open

alabamapaul wants to merge 2 commits into
dbsrgits:masterfrom
alabamapaul:master

Conversation

@alabamapaul

Copy link
Copy Markdown

First and foremost, to work on Windows, IO::All must be patched see IO::All Pull Request #81

After patching my IO::All, I still encountered errors on Windows. To correct those errors, I made the following changes:

  • In t/12-populate-basic.t, DBICTest could not delete the database unless you disconnected first.
    • Forcing the $schema variable out of scope causes the disconnect, allowing the database to be deleted.
  • In t/compile.t, failed on Windows because regex assumed Linux path separator / but on Windows the path separator is .
    • Using File::Spec and File::Basename makes tests OS independent.

Forcing the $schema variable out of scope causes the database to
disconnect which allows the database to be deleted on Windows platforms
Previously was failing on Windows because path separator is \ not /.
Using File::Spec makes this OS independent.
@samuelckaufman

Copy link
Copy Markdown
Contributor

Hey @alabamapaul sorry for the delay, I read this a week ago and think it's awesome, just had not had a minute.
I'll review the changes this week and try to get a release out.
Thanks!

@TBSliver

TBSliver commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

@ediblenergy can we get this merged? just ran headfirst into this issue :) plzkthxbai! :P

@samuelkaufman

Copy link
Copy Markdown

@TBSliver sure I'll give it a shot tomorrow morning.

@TBSliver

Copy link
Copy Markdown
Contributor

@ediblenergy ohai, turns out I ran into this 2 years ago, and now i've ran into it again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants