Changes to allow MSWin32 to PASS - #9
Open
alabamapaul wants to merge 2 commits into
Open
alabamapaul wants to merge 2 commits into
alabamapaul wants to merge 2 commits into
Conversation
Forcing the $schema variable out of scope causes the database to disconnect which allows the database to be deleted on Windows platforms
Previously was failing on Windows because path separator is \ not /. Using File::Spec makes this OS independent.
Contributor
|
Hey @alabamapaul sorry for the delay, I read this a week ago and think it's awesome, just had not had a minute. |
Contributor
|
@ediblenergy can we get this merged? just ran headfirst into this issue :) plzkthxbai! :P |
samuelkaufman
approved these changes
Apr 6, 2018
|
@TBSliver sure I'll give it a shot tomorrow morning. |
Contributor
|
@ediblenergy ohai, turns out I ran into this 2 years ago, and now i've ran into it again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First and foremost, to work on Windows, IO::All must be patched see IO::All Pull Request #81
After patching my IO::All, I still encountered errors on Windows. To correct those errors, I made the following changes: